feat: animate error text replacing helper text #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/1tkvsd7a2 |
emyarod
reviewed
Oct 26, 2020
Fix tooltip title for select invalid state gif Co-authored-by: emyarod <emyarod@users.noreply.github.com>
emyarod
approved these changes
Oct 26, 2020
janchild
reviewed
Oct 27, 2020
There was a problem hiding this comment.
@johnbister, these look great. It's nice to see movement on the pages. A couple of content suggestions:
- Dropdown. The helper text and the error message should reference "user" instead of "project" because you're setting the role for the user.
- Select. The same goes for Select; you should reference "user" instead of "project".
That's it! Thanks!
aledavila
approved these changes
Oct 27, 2020
Changing helper/error text to 'user' from 'project'.
Changing helper/error text to 'user' from 'project'.
Changing helper text to 'user' from 'project'.
Changing helper text to 'user' from 'project'.
|
@janchild Good catch! I changed the helper/error text to 'user'. Let me know if you see anything else. Thanks! |
|
@johnbister I actually realized that there are two static images that will need to be updated to the same wording. Are you able to take care of those too? Thank you! Sorry I missed those on the first pass through. They are here: https://carbondesignsystem-git-add-error-text-gifs.carbon-design-system.vercel.app/components/dropdown/usage/#dropdown |
Fix helper text to show 'user' instead of 'project'.
Fix helper text to show 'user' instead of 'project'.
Fix helper text to show 'user' instead of 'project'.
Fix helper text to show 'user' instead of 'project'.
|
@janchild swapped out the static images! |
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…1916) * swap input text error png for gif * swap pattern form error text png to gif * swap dropdown helper text png to gif * swap select helper text png to gif * Update src/pages/components/select/usage.mdx Fix tooltip title for select invalid state gif Co-authored-by: emyarod <emyarod@users.noreply.github.com> * Delete dropdown-usage-14.gif Changing helper/error text to 'user' from 'project'. * Add dropdown-usage-14.gif Changing helper/error text to 'user' from 'project'. * Delete select-usage-1.gif Changing helper text to 'user' from 'project'. * Add fixed select-usage-1.gif Changing helper text to 'user' from 'project'. * Delete dropdown-usage-9a.png Fix helper text to show 'user' instead of 'project'. * Delete dropdown-usage-9b.png Fix helper text to show 'user' instead of 'project'. * Add dropdown-usage-9a.png Fix helper text to show 'user' instead of 'project'. * Add dropdown-usage-9b.png Fix helper text to show 'user' instead of 'project'. Co-authored-by: emyarod <emyarod@users.noreply.github.com> Co-authored-by: Alessandra Davila <aledavila@ibm.com>
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
…1916) * swap input text error png for gif * swap pattern form error text png to gif * swap dropdown helper text png to gif * swap select helper text png to gif * Update src/pages/components/select/usage.mdx Fix tooltip title for select invalid state gif Co-authored-by: emyarod <emyarod@users.noreply.github.com> * Delete dropdown-usage-14.gif Changing helper/error text to 'user' from 'project'. * Add dropdown-usage-14.gif Changing helper/error text to 'user' from 'project'. * Delete select-usage-1.gif Changing helper text to 'user' from 'project'. * Add fixed select-usage-1.gif Changing helper text to 'user' from 'project'. * Delete dropdown-usage-9a.png Fix helper text to show 'user' instead of 'project'. * Delete dropdown-usage-9b.png Fix helper text to show 'user' instead of 'project'. * Add dropdown-usage-9a.png Fix helper text to show 'user' instead of 'project'. * Add dropdown-usage-9b.png Fix helper text to show 'user' instead of 'project'. Co-authored-by: emyarod <emyarod@users.noreply.github.com> Co-authored-by: Alessandra Davila <aledavila@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1653
Changelog
Swapping a few pngs for gifs to add clarification for usage.
Added
text-input-usage-2.gif
inline-error-message.gif
dropdown-usage-14.gif
select-usage-1.gif
Removed
text-input-usage-2.png
Inline_error_message.png
dropdown-usage-14.png
select-usage-1.png
Test/Review
New gifs can be reviewed at:
components>text input>usage>validation and errors
patterns>forms>client side validation
components>dropdown>usage>invalid
components>select>usage>validation