Skip to content

Commit

Permalink
feat: animate error text replacing helper text (#1916)
Browse files Browse the repository at this point in the history
* swap input text error png for gif

* swap pattern form error text png to gif

* swap dropdown helper text png to gif

* swap select helper text png to gif

* Update src/pages/components/select/usage.mdx

Fix tooltip title for select invalid state gif

Co-authored-by: emyarod <emyarod@users.noreply.github.com>

* Delete dropdown-usage-14.gif

Changing helper/error text to 'user' from 'project'.

* Add dropdown-usage-14.gif

Changing helper/error text to 'user' from 'project'.

* Delete select-usage-1.gif

Changing helper text to 'user' from 'project'.

* Add fixed select-usage-1.gif

Changing helper text to 'user' from 'project'.

* Delete dropdown-usage-9a.png

Fix helper text to show 'user' instead of 'project'.

* Delete dropdown-usage-9b.png

Fix helper text to show 'user' instead of 'project'.

* Add dropdown-usage-9a.png

Fix helper text to show 'user' instead of 'project'.

* Add dropdown-usage-9b.png

Fix helper text to show 'user' instead of 'project'.

Co-authored-by: emyarod <emyarod@users.noreply.github.com>
Co-authored-by: Alessandra Davila <aledavila@ibm.com>
  • Loading branch information
3 people authored Nov 2, 2020
1 parent 1fed6d1 commit c926686
Show file tree
Hide file tree
Showing 14 changed files with 6 additions and 6 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file modified src/pages/components/dropdown/images/dropdown-usage-9a.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/dropdown/images/dropdown-usage-9b.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions src/pages/components/dropdown/usage.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ functionality—dropdown, multiselect, and combo box.
| Type | Purpose |
| --------------------------- | -------------------------------------------------------------------------------------------------------- |
| [Dropdown](#dropdown) | Allows the user to select one option from a list. |
| [Multiselect](#multiselect)| Allows the user to select multiple options from a list and filter. |
| [Combo box](#combo-box) | Allows a user to enter any value, or select a value from a list of suggested, likely, or desired values. |
| [Multiselect](#multiselect) | Allows the user to select multiple options from a list and filter. |
| [Combo box](#combo-box) | Allows a user to enter any value, or select a value from a list of suggested, likely, or desired values. |

#### When to use

Expand Down Expand Up @@ -662,7 +662,7 @@ usage page.
<Row>
<Column colLg={8}>

![Dropdown invalid state.](images/dropdown-usage-14.png)
![Dropdown invalid state.](images/dropdown-usage-14.gif)

</Column>
</Row>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
2 changes: 1 addition & 1 deletion src/pages/components/select/usage.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ the user is filling out forms. For full guidelines, refer to the
<Row>
<Column colLg={8}>

![Example of a small select](images/select-usage-1.png)
![Select invalid state](images/select-usage-1.gif)

</Column>
</Row>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
2 changes: 1 addition & 1 deletion src/pages/components/text-input/usage.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ the user is filling out forms. For full guidelines, refer to the
<Row>
<Column colLg={8}>

![Validation text example](images/text-input-usage-2.png)
![Validation text example](images/text-input-usage-2.gif)

</Column>
</Row>
Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/pages/patterns/forms-pattern/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ Common user errors include:
<Row>
<Column colLg={8}>

![Example of client-side error message](/images/Inline_error_message.png)
![Example of client-side error message](/images/inline-error-message.gif)

</Column>
</Row>
Expand Down

1 comment on commit c926686

@vercel
Copy link

@vercel vercel bot commented on c926686 Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.