Nicer handling of job not found on the job details view #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nancyc12
previously approved these changes
Jul 3, 2024
Co-authored-by: Nancy Chen <nancy.chen@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You won't get there accidentally by clicking, but if you try to go to the job details page for an invalid job_id, you'll get a confusing error response of
Unhandled Exception: 'None' has no attribute 'job_data'and it'll hit the server logs as an error because we aren't handling it. This just makes a nicer 404 page for it like we did for the similar situation with agent detailsResolved issues
N/A
Documentation
N/A
Web service API changes
N/A
Tests
Added unit test and also tested locally