Nicer handling of job not found on the job details view (#295)

* Nicer handling of job not found on the job details view

* Update server/src/views.py

Co-authored-by: Nancy Chen <nancy.chen@canonical.com>

---------

Co-authored-by: Nancy Chen <nancy.chen@canonical.com>

server/src/templates/job_not_found.html

@@ -0,0 +1,11 @@
+{% extends 'base.html' %}
+{% set active_page = 'jobs' %}
+{% block content %}
+<div class="p-strip is-shallow">
+    <div class="row">
+        <h1 class="p-heading--3">
+            Job not found: {{ job_id }}
+        </h1>
+    </div>
+</div>
+{% endblock %}

server/src/views.py

@@ -74,6 +74,11 @@ def jobs():
 def job_detail(job_id):
     """Job detail view"""
     job_data = mongo.db.jobs.find_one({"job_id": job_id})
+    if not job_data:
+        response = make_response(
+            render_template("job_not_found.html", job_id=job_id), 404
+        )
+        return response
     return render_template("job_detail.html", job=job_data)
 
 

server/tests/test_views.py

@@ -19,7 +19,7 @@
 
 import mongomock
 from mock import patch
-from src.views import queues_data, agent_detail
+from src.views import job_detail, queues_data, agent_detail
 
 
 def test_queues():
@@ -96,3 +96,17 @@ def test_agent_not_found(testapp):
 
     assert "Agent not found: agent1" in str(response.data)
     assert response.status_code == 404
+
+
+def test_job_not_found(testapp):
+    """
+    Test that the job_detail fails gracefully when a job is not found
+    """
+
+    mongo = mongomock.MongoClient()
+    with patch("src.views.mongo", mongo):
+        with testapp.test_request_context():
+            response = job_detail("job1")
+
+    assert "Job not found: job1" in str(response.data)
+    assert response.status_code == 404