Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): bump artifact actions to v4 #193

Merged
merged 1 commit into from
Jan 21, 2025
Merged

chore(ci): bump artifact actions to v4 #193

merged 1 commit into from
Jan 21, 2025

Conversation

zhijie-yang
Copy link
Contributor

  • Have you signed the CLA?

Bumps upload-artifact and download-artifact actions to v4, as v3 is deprecated.

Associated workflow run: https://github.com/canonical/chisel/actions/runs/12812400771/job/35723950707?pr=192#step:1:36

Ref: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@zhijie-yang zhijie-yang mentioned this pull request Jan 16, 2025
Merged
1 task
@zhijie-yang zhijie-yang added the Simple Nice for a quick look on a minute or two label Jan 16, 2025
cjdcordeiro
cjdcordeiro approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump

@cjdcordeiro cjdcordeiro requested a review from letFunny January 16, 2025 16:31
letFunny
letFunny approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

niemeyer
niemeyer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@niemeyer niemeyer merged commit b6de199 into canonical:main Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niemeyer niemeyer niemeyer approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@letFunny letFunny letFunny approved these changes

Assignees
No one assigned
Labels
Simple Nice for a quick look on a minute or two
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhijie-yang @niemeyer @cjdcordeiro @letFunny