Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(snap): add security advisory and contact email #192

Merged
merged 3 commits into from
Jan 21, 2025
Merged

chore(snap): add security advisory and contact email #192

merged 3 commits into from
Jan 21, 2025

Conversation

zhijie-yang
Copy link
Contributor

  • Have you signed the CLA?

Adds the security advisory link and security contact email to the snap metadata.

@zhijie-yang
Copy link
Contributor Author

Workflow failure due to deprecated [up|down]load-artifact@v3 actions. Awaiting #193 .

@zhijie-yang zhijie-yang marked this pull request as draft January 17, 2025 09:31
cjdcordeiro
cjdcordeiro requested changes Jan 17, 2025
View reviewed changes
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro marked this pull request as ready for review January 17, 2025 16:16
@cjdcordeiro cjdcordeiro added the Simple Nice for a quick look on a minute or two label Jan 17, 2025
rebornplusplus
rebornplusplus approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@niemeyer niemeyer merged commit 717fecd into canonical:main Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@rebornplusplus rebornplusplus rebornplusplus approved these changes

@letFunny letFunny letFunny approved these changes

Assignees
No one assigned
Labels
Simple Nice for a quick look on a minute or two
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhijie-yang @cjdcordeiro @rebornplusplus @letFunny @niemeyer