wasmtime: default to blocking sockets #5633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
approved these changes
Jan 25, 2023
This was referenced Jan 25, 2023
|
what's the status of this? |
This commit is a follow-up on f81a663, in which pre-opened socket support was added, but sockets opened by wasmtime were made to default to non-blocking mode and pre-opened sockets passed to wasmtime via `listenfd` were explicitly set to non-blocking mode. Avoid explicitly setting the mode and use OS default mode in the former case or whichever mode was pre-configured in the latter. Note, that Windows, POSIX and Berkeley sockets are blocking by default. Signed-off-by: Roman Volosatovs <roman@profian.com>
ef99b70 to
612747f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up on f81a663, (#3729)
in which pre-opened socket support was added, but sockets opened by
wasmtime were made to default to non-blocking mode and pre-opened
sockets passed to wasmtime via
listenfdwere explicitly set tonon-blocking mode.
Avoid explicitly setting the mode and use OS default mode in the
former case or whichever mode was pre-configured in the latter.
Note, that Windows, POSIX and Berkeley sockets are blocking by default.