-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI options for preopened listen sockets #3729
Conversation
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
d921e8e
to
6ba0c26
Compare
6ba0c26
to
877f4fb
Compare
This patch implements CLI options to insert pre-opened sockets. `--listenfd` : Inherit environment variables and file descriptors following the systemd listen fd specification (UNIX only). `--tcplisten <SOCKET ADDRESS>`: Grant access to the given TCP listen socket. Signed-off-by: Harald Hoyer <harald@profian.com>
877f4fb
to
6be5273
Compare
rebased |
added |
This looks like it will be a good way to enable experimentation with the new WASI accept functionality. Looking forward, the convention of having applications implicitly assume they can get environment variables like However, we can address that as the pieces needed to use Typed Main come online. For now, this looks good. |
…alliance#3729) This patch implements CLI options to insert pre-opened sockets. `--listenfd` : Inherit environment variables and file descriptors following the systemd listen fd specification (UNIX only). `--tcplisten <SOCKET ADDRESS>`: Grant access to the given TCP listen socket. Signed-off-by: Harald Hoyer <harald@profian.com>
As a follow up for #3711, this implements CLI options to insert pre-opened sockets.
--listenfd
: Inherit environment variables and file descriptors following the systemd listen fd specification (UNIX only)--tcplisten <SOCKET ADDRESS>
: Grant access to the given TCP listen socketTODO
EXAMPLES