Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do more ruffing #1520

Merged
merged 1 commit into from
Jan 14, 2025
Merged

do more ruffing #1520

merged 1 commit into from
Jan 14, 2025

Conversation

srabraham
Copy link
Member

this is a recreation of Tool's PR here, with a few minor tweaks. I agree with his decisions about which checks to just keep ignoring, as each of those has some reason for being less useful than annoying in our codebase.

#1431

this is a recreation of Tool's PR here, with a few minor tweaks.
I agree with his decisions about which checks to just keep ignoring,
as each of those has some reason for being less useful than annoying
in our codebase.

#1431
@srabraham srabraham enabled auto-merge (rebase) January 14, 2025 19:33
@srabraham srabraham merged commit 94d2237 into master Jan 14, 2025
11 checks passed
@srabraham srabraham deleted the 2025-01-14-ruff-fun branch January 14, 2025 19:35
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 72.41379% with 16 lines in your changes missing coverage. Please review.

Project coverage is 69.81%. Comparing base (60079db) to head (c533b88).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ims/application/_api.py 0.00% 5 Missing ⚠️
src/ims/application/_klein.py 0.00% 5 Missing ⚠️
src/ims/ext/klein.py 33.33% 1 Missing and 1 partial ⚠️
src/ims/application/_external.py 0.00% 1 Missing ⚠️
src/ims/directory/clubhouse_db/_dms.py 0.00% 1 Missing ⚠️
src/ims/ext/sqlite.py 66.66% 1 Missing ⚠️
src/ims/run/_options.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
+ Coverage   69.80%   69.81%   +0.01%     
==========================================
  Files         182      182              
  Lines        9170     9167       -3     
  Branches     1510     1508       -2     
==========================================
- Hits         6401     6400       -1     
+ Misses       2659     2657       -2     
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srabraham srabraham mentioned this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant