More ruff #1431
Closed
More ruff #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1431 +/- ##
==========================================
+ Coverage 69.21% 69.22% +0.01%
==========================================
Files 181 181
Lines 8914 8908 -6
Branches 1491 1489 -2
==========================================
- Hits 6170 6167 -3
+ Misses 2645 2642 -3
Partials 99 99 ☔ View full report in Codecov by Sentry. |
srabraham
added a commit
that referenced
this pull request
Jan 14, 2025
this is a recreation of Tool's PR here, with a few minor tweaks. I agree with his decisions about which checks to just keep ignoring, as each of those has some reason for being less useful than annoying in our codebase. #1431
Merged
srabraham
added a commit
that referenced
this pull request
Jan 14, 2025
this is a recreation of Tool's PR here, with a few minor tweaks. I agree with his decisions about which checks to just keep ignoring, as each of those has some reason for being less useful than annoying in our codebase. #1431
|
Done, over here (I wanted to try out these changes myself too): #1520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.