only probe for python if PYBULLET explicitly specified #1409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ubuntu 16.04, despite using
-DBUILD_PYBULLET=OFF
, the build fails with the following error:If we look at the relevant code in CMakeLists.txt:
which FATAL_ERRORs out when it encounters this logic in FindPythonLibs.cmake
This pull request changes the build behavior so that the environment is not probed at all for any Python libraries unless
BUILD_PYBULLET
is explicitly set toON
. The previous behavior was to always probe the environment, then set the default value ofBUILD_PYBULLET
based on whether the probe succeeds.With this change, developers not interested in PYBULLET can isolate themselves from problems related to Python build going forward. The downside is folks that want PYBULLET and previously relied on the automagic probing behavior will now need to explicitly turn it ON.
Previous work: #1340