-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake python config bugs fixed #1131
Conversation
Python and pybullet remain optional with these changes. A specific python version can now be selected by setting PYTHON_VERSION_PYBULLET. The python library version must now match the interpreter version exactly. If all required python dependencies are found, pybullet is now enabled by default. Changes incorporate the following BSD licensed cmake code: https://github.com/BVLC/caffe/blob/32bf5c7ad804ad683aa5ea9382209e9284451e5f/CMakeScripts/FindNumPy.cmake https://github.com/NikolausDemmel/CMake/pull/2/files https://github.com/Kitware/CMake/blob/86578eccf2e82286248796bad1032cd0e3a5e1e2/Modules/SelectLibraryConfigurations.cmake
Still ensures library version matches interpreter version exactly.
A specific python version can now be selected by setting PYTHON_VERSION_PANGOLIN. The python library version must now match the interpreter version exactly. If all required python dependencies are found, pangolin python utilities are now enabled by default. Changes incorporate the following BSD licensed cmake code: https://github.com/BVLC/caffe/blob/32bf5c7ad804ad683aa5ea9382209e9284451e5f/CMakeScripts/FindNumPy.cmake https://github.com/NikolausDemmel/CMake/pull/2/files https://github.com/Kitware/CMake/blob/86578eccf2e82286248796bad1032cd0e3a5e1e2/Modules/SelectLibraryConfigurations.cmake Based on my pull request for the same python cmake issues in pybullet: bulletphysics/bullet3#1131 bulletphysics/bullet3#1107
Thanks for the work on this. I will test it on a few platforms before merging. |
Okay, I tried to be aware of that concern. It should try and ensure if any problems are detected python automatically switches off, standard warnings are printed, and the cmake configuration + build continues & succeeds without python. |
Thanks for the contribution, looks good to me! |
People report issues with cmake and python, and the continuous integration also fails. |
Changes incorporate the following BSD licensed cmake code:
https://github.com/BVLC/caffe/blob/32bf5c7ad804ad683aa5ea9382209e9284451e5f/CMakeScripts/FindNumPy.cmake
https://github.com/NikolausDemmel/CMake/pull/2/files
https://github.com/Kitware/CMake/blob/86578eccf2e82286248796bad1032cd0e3a5e1e2/Modules/SelectLibraryConfigurations.cmake
This addresses many of the cmake issues blocking #1107