Convert Event to Kotlin and remove EventInternal #1951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
* fix(payload size) added error call back to make the payload size more consistent * Convert file store and subclasses to kotlin (#1929) * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * Feature flags should be modified in-place. (#1940) * fix(feature flags) refactor feature flags are modified in-place. * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * fix(payload size) adjusted end to end test
… cannot be double-freed
|
The current effect on the public API surface means this PR currently introduces more problems than it really solves. Closing until this can be addressed properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert Event.java to kotlin class and integrate EventInternal to Event
Testing
Existing tests