Feature flags should be modified in-place. #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Nov 27, 2023
639a862 to
29c5062
Compare
added 2 commits
November 27, 2023 11:48
* fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack
ghost
pushed a commit
that referenced
this pull request
Nov 27, 2023
* fix(feature flags) refactor feature flags are modified in-place. * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack
ghost
pushed a commit
that referenced
this pull request
Nov 28, 2023
* fix(payload size) added error call back to make the payload size more consistent * Convert file store and subclasses to kotlin (#1929) * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * Feature flags should be modified in-place. (#1940) * fix(feature flags) refactor feature flags are modified in-place. * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * fix(payload size) adjusted end to end test
ghost
pushed a commit
that referenced
this pull request
Dec 5, 2023
* fix(payload size) added error call back to make the payload size more consistent * Convert file store and subclasses to kotlin (#1929) * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * Feature flags should be modified in-place. (#1940) * fix(feature flags) refactor feature flags are modified in-place. * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * fix(payload size) adjusted end to end test
Merged
ghost
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Update workflow to use auth provided by bearer token * docs(upgrade guide): expanded UG content and a few corrections to changelog * docs(upgrade guide): emphasis stability score calculation * docs(upgrade guide): add persist user change * Convert file store and subclasses to kotlin (#1929) * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * ANR Scenario session should be allowed to terminate properly (#1948) * fix(anr scenario ) add more time to wait for appium to figure out which session is terminated * v6.0.0 * corrections to fix v6 publishing * add the exitinfo module to the publishing step * fix(foreground): ensure inForeground is set correctly when the app is backgrounded, and reintroduce the test scenario * chore(changelog): updated changelog to reflect new release date for v6.0.0 * Update workflow to use auth provided by bearer token * docs(upgrade guide): expanded UG content and a few corrections to changelog * docs(upgrade guide): emphasis stability score calculation * docs(upgrade guide): add persist user change --------- Co-authored-by: jason <lemnik@users.noreply.github.com> Co-authored-by: Alex Moinet <alex@bugsnag.com> Co-authored-by: Tom Longridge <tom.longridge@smartbear.com> * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * Feature flags should be modified in-place. (#1940) * fix(feature flags) refactor feature flags are modified in-place. * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * Consistent payload (#1949) * fix(payload size) added error call back to make the payload size more consistent * Convert file store and subclasses to kotlin (#1929) * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * fix(code convert) add FileStore, sessionStore and EventStore Kotlin classes * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * Feature flags should be modified in-place. (#1940) * fix(feature flags) refactor feature flags are modified in-place. * Time limitation for thread collection (#1935) * fix(threadStack timeout) add time limitation for thread stack * fix(threadStack timeout) add time limitation for thread stack * fix(payload size) adjusted end to end test * fix(ndk): replace `static_json_data` with an atomic to ensure that it cannot be double-freed * release/v6.1.0 --------- Co-authored-by: Jason <lemnik@users.noreply.github.com> Co-authored-by: Alex Moinet <alex@bugsnag.com> Co-authored-by: Tom Longridge <tom.longridge@smartbear.com> Co-authored-by: Tom Longridge <tom@bugsnag.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Feature flags position will be in the place when it is added.
Changeset
Feature flags would not be added to the end of the collection when it is modified.
Testing
Exiting unit tests