Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

Introduce new env CHROME_USER_DATA_DIR_FOR_TEST for test use #384

Closed
wants to merge 1 commit into from

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 9, 2017

fix #383

Auditors: @bridiver, @bsclifton, @ayumi

See brave/browser-laptop#11879 for where this new flag is used

@darkdh darkdh self-assigned this Nov 9, 2017
darkdh added a commit to brave/browser-laptop that referenced this pull request Nov 9, 2017
@darkdh
Copy link
Member Author

darkdh commented Nov 9, 2017

The app.relaunch API will eventually call base::LaunchProcess which will do a fork operation and inherits the environment variables so that is why we need a new one for relaunch case

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested this (with and without the change). Works great! 😄 👍

@bsclifton
Copy link
Member

Holding off on merge until @bridiver can review

@darkdh
Copy link
Member Author

darkdh commented Nov 10, 2017

closed by #383 (comment)

@darkdh darkdh closed this Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app.relaunch() ignores user-data-dir-name switch
2 participants