Skip to content
This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

app.relaunch() ignores user-data-dir-name switch #383

Closed
darkdh opened this issue Nov 9, 2017 · 1 comment
Closed

app.relaunch() ignores user-data-dir-name switch #383

darkdh opened this issue Nov 9, 2017 · 1 comment
Assignees

Comments

@darkdh
Copy link
Member

darkdh commented Nov 9, 2017

apply this diff to browser-laptop and do npm start

diff --git a/app/index.js b/app/index.js
index 171df629b..ab75593b8 100644
--- a/app/index.js
+++ b/app/index.js
@@ -74,6 +74,15 @@ const settings = require('../js/constants/settings')
 const {getSetting} = require('../js/settings')
 const BookmarksExporter = require('./browser/bookmarksExporter')

+console.log(process.argv)
+if (!process.argv.includes('--relaunch')) {
+  const args = process.argv.filter((item) => {
+    return item.indexOf('--user-data-dir-name=') === -1
+  })
+  console.log(args.slice(1).concat(['--user-data-dir-name=brave-test', '--relaunch']))
+  app.relaunch({args: args.slice(1).concat(['--user-data-dir-name=brave-test', '--relaunch'])})
+  app.exit()
+}
 app.commandLine.appendSwitch('enable-features', 'BlockSmallPluginContent,PreferHtmlOverPlugins')

 // Domains to accept bad certs for. TODO: Save the accepted cert fingerprints.

It still uses brave-development as user folder instead of brave-test after relaunched

@darkdh
Copy link
Member Author

darkdh commented Nov 10, 2017

@bridiver suggest we can set process.env.CHROME_USER_DATA_DIR = null or delete process.env.CHROME_USER_DATA_DIR before relaunch.
I verified it works great so close this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant