-
Notifications
You must be signed in to change notification settings - Fork 971
Conversation
} | ||
}, | ||
// applies for primary and white buttons | ||
browserButton_default: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to see the modifed BEM style :-)
Nice work. As a reminder, would you please apply the change to |
sure, thanks for checking ;) |
btw @luixxiul I added #8568 as an issue to track this PR since it doesn't refactor all components and removed #7168 reference (added you there as assignee as well) so we can keep tracking until every button uses BrowserButton. Then There are too many files using (now legacy) Button that the likeliness of regression was too high, so I decided to keep it gradual. |
FYI: reset Sync will be replaced with the primaryButton after #8044 is merged. |
@cezaraugusto I left some comments. |
thanks, updated |
- Close #8568 - Auditors: @luixxiul, @NejcZdovc
Since comments were addressed, merging. |
As I removed Since on the other dialogs the margin exists, I believe something is inconsistent between them. I'll tackle that. |
@luixxiul is that expected behaviour for the backup wallet modal? |
No, and it was fixed already |
git rebase -i
to squash commits (if needed).Auditors: @luixxiul, @NejcZdovc
Close: #8568
Test Plan:
Buttons refactored
Buttons changed as side effect
We had a global selector that changed every button that had
Button
className. I replaced that withnormalizeButton
so standard HTML5 buttons weren't affected. For reference: