Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression: margin between buttons on backup brave wallet dialog #8736

Closed
luixxiul opened this issue May 6, 2017 · 1 comment
Closed

Regression: margin between buttons on backup brave wallet dialog #8736

luixxiul opened this issue May 6, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 6, 2017

Test plan

#8737 (comment)


Describe the issue you encountered: #8560 (comment)

As I removed .paymentsContainer the margin between the buttons on "Back up your Brave wallet" dialog have regressed. The specification here seems to be no longer applied: https://github.com/brave/browser-laptop/blob/master/less/button.less#L180

clipboard01

Since on the other dialogs the margin exists, I believe something is inconsistent between them. I'll tackle that.

  • Brave Version (revision SHA): 0.15.3 preview 3

  • Steps to reproduce:

    1. Open about:preferences#payments
    2. Open advanced settings
    3. Click "Back up your wallet"
  • Actual result:
    clipboard01

  • Expected result: there should be margin between each button

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@luixxiul luixxiul added this to the 0.15.3 milestone May 6, 2017
@luixxiul luixxiul self-assigned this May 6, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented May 6, 2017

I misunderstood the issue but found the solution anyway. I'll push a fix soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.