Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Preserve order when exporting bookmarks #7195

Merged
merged 1 commit into from
Feb 11, 2017
Merged

Preserve order when exporting bookmarks #7195

merged 1 commit into from
Feb 11, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 11, 2017

Test Plan:

  1. Import a lot of bookmarks.
  2. Export bookmarks to a file. (file A)
  3. Delete all the bookmarks
  4. Import from file A
  5. The bookmarks order should be the same as step 1

fix #7189

Auditors: @bbondy, @NejcZdovc

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix brave#7189

Auditors: @bbondy, @NejcZdovc

Test Plan:
1. Import a lot of bookmarks.
2. Export bookmarks to a file. (file A)
3. Delete all the bookmarks
4. Import from file A
5. The bookmarks order should be the same as step 1
@darkdh darkdh added this to the 0.13.3 milestone Feb 11, 2017
@darkdh darkdh self-assigned this Feb 11, 2017
@darkdh darkdh requested review from bbondy and NejcZdovc February 11, 2017 09:04
@bbondy
Copy link
Member

bbondy commented Feb 11, 2017

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported bookmarks are not retaining order
3 participants