Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Exported bookmarks are not retaining order #7189

Closed
alexwykoff opened this issue Feb 11, 2017 · 1 comment · Fixed by #7195
Closed

Exported bookmarks are not retaining order #7189

alexwykoff opened this issue Feb 11, 2017 · 1 comment · Fixed by #7195

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Feb 11, 2017

Test plan

#7195 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When exporting and importing the exported file, it was found that order was not maintained.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version (revision SHA):
    0.13.3 RC 1 7024e09

  • Steps to reproduce: (with a clean profile)

    1. Import a lot of bookmarks.
    2. Export bookmarks to a file. (file A)
    3. Import File A.
    4. Export bookmarks to a file. (file B)
    5. Import File B.
    6. Repeat a few more times and then do a diff of the exported files.
  • Actual result:
    None of the files match.

  • Expected result:
    If the importer keeps bookmarks in order, and the exporter keeps bookmarks in order, and no new bookmarks were created, edited, or deleted, then the files should be identical.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@darkdh
Copy link
Member

darkdh commented Feb 11, 2017

separated re-import issue to #7194

Updated STR:

  1. Import a lot of bookmarks.
  2. Export bookmarks to a file. (file A)
  3. Delete all the bookmarks
  4. Import from file A
  5. The bookmarks order should be the same as step 1

@darkdh darkdh changed the title Exported then Imported bookmarks are not retaining order Exported bookmarks are not retaining order Feb 11, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Feb 11, 2017
fix brave#7189

Auditors: @bbondy, @NejcZdovc

Test Plan:
1. Import a lot of bookmarks.
2. Export bookmarks to a file. (file A)
3. Delete all the bookmarks
4. Import from file A
5. The bookmarks order should be the same as step 1
@darkdh darkdh self-assigned this Feb 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.