This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Retool the ledger updates into the 0.13.1-branch #6706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something seems to be wrong according to Travis: https://travis-ci.org/brave/browser-laptop/builds/192881925#L4354 |
|
@luixxiul I believe the Chromedriver for latest version is not uploaded. We'll likely need new prebuilts |
d2028be to
9d038a4
Compare
|
@bsclifton - can we please get this into either master or 0.13.1 ? thanks! |
|
Rebase needed |
2e7c6ce to
7ee5856
Compare
This was referenced Jan 19, 2017
7ee5856 to
c5a1165
Compare
bsclifton
reviewed
Jan 20, 2017
There was a problem hiding this comment.
I re-ran tests which failed during CI, all except 1 passed. The one which kept failing appears to have been caused by an unrelated commit.
Ready for merge 😄
Closed
This was referenced Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditor @bsclifton
Fixes #6551
Fixes #6592
Test Plan