Fix search autocomplete

Fix #6696

Broke from a recent fix I made from the refactor

Auditors: @bsclifton

Author: bbondy

app/renderer/fetchSearchSuggestions.js

@@ -16,6 +16,6 @@ const fetchSearchSuggestions = debounce((tabId, autocompleteURL, searchTerms) =>
     // Once we have the online suggestions, append them to the others
     windowActions.searchSuggestionResultsAvailable(tabId, Immutable.fromJS(xhr.response[1]))
   }
-}, 50)
+}, 100)
 
 module.exports = fetchSearchSuggestions

app/renderer/reducers/urlBarSuggestionsReducer.js

@@ -39,7 +39,7 @@ const updateSearchEngineInfoFromInput = (state, frameProps) => {
           return state
         }
       }
-      state = state.setIn(searchDetailPath, Immutable.fromJS({}))
+      state = state.deleteIn(searchDetailPath)
     }
   }
   return state
@@ -342,6 +342,7 @@ const urlBarSuggestionsReducer = (state, action) => {
     case windowConstants.WINDOW_SEARCH_SUGGESTION_RESULTS_AVAILABLE:
       const frameKey = getFrameKeyByTabId(state, action.tabId)
       state = state.setIn(frameStatePath(state, frameKey).concat(['navbar', 'urlbar', 'suggestions', 'searchResults']), action.searchResults)
+      state = generateNewSuggestionsList(state)
       break
     case windowConstants.WINDOW_SET_NAVBAR_INPUT:
       const activeFrameProps = getActiveFrame(state)

test/components/urlBarSuggestionsTest.js

@@ -1,7 +1,8 @@
-/* global describe, it, beforeEach */
+/* global describe, it, before, beforeEach */
 
 const Brave = require('../lib/brave')
 const messages = require('../../js/constants/messages')
+const settings = require('../../js/constants/settings')
 const {urlInput, urlBarSuggestions} = require('../lib/selectors')
 
 describe('urlBarSuggestions', function () {
@@ -164,6 +165,28 @@ describe('urlBarSuggestions', function () {
       .waitForVisible(urlBarSuggestions)
       .waitForExist(urlBarSuggestions + ' li.suggestionItem[data-index="0"]:not(.selected)')
       .keys(Brave.keys.ENTER)
-      .waitForInputText(urlInput, /google.com\/.*q=ave/)
+      .waitForInputText(urlInput, /google.*\/.*q=ave/)
+  })
+})
+
+describe('search suggestions', function () {
+  Brave.beforeAll(this)
+
+  before(function * () {
+    yield this.app.client
+      .waitForUrl(Brave.newTabUrl)
+      .waitForBrowserWindow()
+      .waitForVisible(urlInput)
+  })
+
+  it('Finds search suggestions and performs a search when selected', function * () {
+    yield this.app.client
+      .changeSetting(settings.OFFER_SEARCH_SUGGESTIONS, true)
+      .setInputText(urlInput, 'what is')
+      .waitForVisible(urlBarSuggestions)
+      .keys(Brave.keys.DOWN)
+      .waitForExist(urlBarSuggestions + ' li.suggestionItem[data-index="0"]:not(.selected)')
+      .keys(Brave.keys.ENTER)
+      .waitForInputText(urlInput, /google.*\/.*q=what\+is/)
   })
 })

test/lib/brave.js

@@ -391,6 +391,7 @@ var exports = {
             } else {
               ret = val === input
             }
+            logVerbose('Current val: ' + val)
             logVerbose('waitForInputText("' + selector + '", "' + input + '") => ' + ret)
             return ret
           })