This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Update disabledContent.js to the modified BEM style #10337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #10336 Auditors: @cezaraugusto Test Plan: 1. Open about:preferences#payments 2. Disable Payments 3. Make sure the left and right rows are displayed properly 4. Enable Payments 5. Make sure the left margin of the gray block does not change
luixxiul
commented
Aug 8, 2017
| backgroundColor: globalStyles.color.lightGray, | ||
| borderRadius: globalStyles.radius.borderRadiusUIbox, | ||
| boxSizing: 'border-box', |
There was a problem hiding this comment.
This one, removing the width below, does the trick.
luixxiul
commented
Aug 8, 2017
| fontSize: '18px', | ||
| margin: '70px 0 -15px 12px' |
There was a problem hiding this comment.
minus value is not so intuitive so it was replaced
luixxiul
commented
Aug 8, 2017
| }, | ||
|
|
||
| paymentsSidebar: { | ||
| opacity: 0.8, |
There was a problem hiding this comment.
this one was removed, applying it to disabledContent__sidebar__header and disabledContent__sidebar__text, to display the logos without opacity.
luixxiul
commented
Aug 8, 2017
| paddingBottom: '0.5em' | ||
| disabledContent__sidebar: { | ||
| minWidth: '200px', | ||
| marginLeft: '35px' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10336
Auditors: @cezaraugusto
Test Plan:
Updated screenshot for reference
Old screenshots
This PR only intends to convert the stuff into the BEM style, so if those look familiar, then it should be fine :-)
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests