Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update disabledContent.js to the modified BEM style #10336

Closed
luixxiul opened this issue Aug 8, 2017 · 0 comments
Closed

Update disabledContent.js to the modified BEM style #10336

luixxiul opened this issue Aug 8, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 8, 2017

Test plan

#10337 (comment)


Describe the issue you encountered: Update disabledContent.js to the modified BEM style (ref: https://github.com/brave/browser-laptop/blob/master/docs/style.md#defining-our-blocks-elements-and-modifiers).

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Actual result: the left margin between the gray area and the left main sidebar changes slightly. It will be addressed at the same time.

    width

  • Expected result: it should not change

  • Extra QA steps:

    1. Open about:preferences#payments
    2. Disable Payments
    3. Make sure the left and right rows are displayed properly
    4. Enable Payments
    5. Make sure the left margin of the gray block does not change
  • Screenshot if needed:
    it should look like this:
    screenshot 2017-08-09 0 48 01

  • Any related issues: Fix BEM naming on enabledContent.js #10146

@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Aug 8, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 8, 2017
@luixxiul luixxiul self-assigned this Aug 8, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants