Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Favicon of trakt.tv on new tab page #5868

Closed
darkdh opened this issue Nov 28, 2016 · 7 comments
Closed

Favicon of trakt.tv on new tab page #5868

darkdh opened this issue Nov 28, 2016 · 7 comments

Comments

@darkdh
Copy link
Member

darkdh commented Nov 28, 2016

Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
The favicon blends in with the red background
Expected behavior:
favicon of trakt.tv should be recognizable

  • Platform (Win7, 8, 10? macOS? Linux distro?): all

  • Brave Version: 0.12.10

  • Screenshot if needed:

The right most red one is trakt.tv
screen shot 2016-11-28 at 16 03 52

Its favicon is
screen shot 2016-11-28 at 16 04 32

cc @bradleyrichter , @cezaraugusto , @bsclifton

@bsclifton
Copy link
Member

Another great example of this one- youtube:
screen shot 2016-11-28 at 10 49 01 pm

@bradleyrichter
Copy link
Contributor

@cezaraugusto Is trying a 90% opacity on the BG color to keep the icon visible without changing the look too much.

@bsclifton
Copy link
Member

Another similar issue:
#5858

In this case, the computed colors are different based on your login state (see pic). What's weird is that those colors may impact brand recognition

@bsclifton
Copy link
Member

bsclifton commented Nov 29, 2016

One way we could solve this would be to first look for the Microsoft attributes. On Twitter for example, they provide this:

<meta name="msapplication-TileImage" content="//abs.twimg.com/favicons/win8-tile-144.png"/>
<meta name="msapplication-TileColor" content="#00aced"/>

This is similar to the suggestion by Cezar in #5663

@cndouglas
Copy link

That's basically the suggestion in #5658.

@bsclifton
Copy link
Member

@liunkae yes! thanks for posting (I was searching and was unable to find that 😄 )

@luixxiul
Copy link
Contributor

Test plan: #5984 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.