Some favicons on new tab page look strange

[jkup]

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:

@bsclifton @cezaraugusto I'm not sure if you already have an issue for this, I checked but couldn't find one. On my new tab page, the Twitter favicon is blue on green instead of blue on white.

Expected behavior:
It should be blue on white.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  macOS

• Brave Version:
  0.12.10

• Steps to reproduce:

  1. Open Brave
  2. Visit Twitter (enough times for it to show up on your new tab page)
  3. Open a new tab

• Screenshot if needed:

• Any related issues:

[jkup]

Is this maybe fixed on master? Now I'm seeing it correctly!

[cezaraugusto]

For tiles' background we rely on site's themeColor. I think that at some point Twitter decided to output themeColor based on account colors (like, mine was black, Brave was orange, etc). But it seems to be removed now.

[jkup]

@cezaraugusto ahhh that's good to know! Thanks for the follow-up, I'll close the issue!

[bradleyrichter]

Ideally we could find some good code to get a dominant color from the site favicon. This may be more reliable for the tiles. Safari uses this.

The next best thing is to make a table of favicons and tile colors for the big sites.