Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add better resolution favicon for new tab topSites #5663

Closed
cezaraugusto opened this issue Nov 16, 2016 · 3 comments
Closed

Add better resolution favicon for new tab topSites #5663

cezaraugusto opened this issue Nov 16, 2016 · 3 comments

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Nov 16, 2016

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
Some websites (such as Youtube) doesn't display a good quality favicon by default, and appear pixelated on new tab's topSites.

Per Brad's request here (#3001) we should:

build high-res favicon collector mechanism, pulled from page header at domain root page

Expected behavior:
TopSites should have an aesthetically pleasing favicon.

My suggestion here:

I was thinking on getting images following Apple > MS conventions on links/meta icon declarations, then search for a given pattern for high res icons (maybe look for size attr, or maybe a given number). If all else fails we fallback to default *.ico images we already have. Like:

1. Search for Apple name convention
<link rel="apple-touch-icon" href="http://example.com/apple-touch-icon.png">

2. Search for MS name convention (tile pictures)
<meta name="msapplication-TileImage" content="http://example.com/mstile-72x72.png">

3. Search for any name convention for high-res icons (find for NxN occurencies or sizes attr)
<link type="image/png" rel="icon" href="http://example.com/something-144x144.png" sizes="144x144">

4. Fallback for default *.ico images

@cndouglas
Copy link

Related: #5658

@luixxiul
Copy link
Contributor

I like the suggestion, still the background color should also be configurable to avoid the issue I mentioned on #5658

@bbondy
Copy link
Member

bbondy commented Nov 22, 2016

Could I also ask that as part o this you re-use the favicon always for the sites that have them, that way they won't get overwritten at some point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants