Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add disposition to windowOpts
Browse files Browse the repository at this point in the history
fix #6483

Auditors: @bridiver, @bbondy

Test Plan:
1. Go to http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open5
2. Click "Try it"
3. Popup window should be opened without pinned tab
  • Loading branch information
darkdh committed Jan 25, 2017
1 parent 5a89948 commit a8d33f4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions app/browser/tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,9 @@ const api = {
}

if (disposition === 'new-window' || disposition === 'new-popup') {
const windowOpts = makeImmutable(size)
appActions.newWindow(makeImmutable(frameOpts), windowOpts)
const windowOpts = size
windowOpts.disposition = disposition

This comment has been minimized.

Copy link
@bridiver

bridiver Jan 25, 2017

Collaborator

disposition is already in the frameOpts, do we need it in both?

This comment has been minimized.

Copy link
@darkdh

darkdh Jan 25, 2017

Author Member

I think it's not necessary. I will do a follow up commit for refactoring it. Thanks.

appActions.newWindow(makeImmutable(frameOpts), makeImmutable(windowOpts))
} else {
let hostWebContents = source.hostWebContents || source
hostWebContents.send(messages.SHORTCUT_NEW_FRAME, location, { frameOpts })
Expand Down

1 comment on commit a8d33f4

@bsclifton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Please sign in to comment.