This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 970
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix #6483 Auditors: @bridiver, @bbondy Test Plan: 1. Go to http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open5 2. Click "Try it" 3. Popup window should be opened without pinned tab
- Loading branch information
Showing
1 changed file
with
3 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,8 +72,9 @@ const api = { | |
} | ||
|
||
if (disposition === 'new-window' || disposition === 'new-popup') { | ||
const windowOpts = makeImmutable(size) | ||
appActions.newWindow(makeImmutable(frameOpts), windowOpts) | ||
const windowOpts = size | ||
windowOpts.disposition = disposition | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
darkdh
Author
Member
|
||
appActions.newWindow(makeImmutable(frameOpts), makeImmutable(windowOpts)) | ||
} else { | ||
let hostWebContents = source.hostWebContents || source | ||
hostWebContents.send(messages.SHORTCUT_NEW_FRAME, location, { frameOpts }) | ||
|
1 comment
on commit a8d33f4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
disposition is already in the frameOpts, do we need it in both?