Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinned Tabs are Present in all Windows #6483

Closed
jonathansampson opened this issue Dec 31, 2016 · 4 comments
Closed

Pinned Tabs are Present in all Windows #6483

jonathansampson opened this issue Dec 31, 2016 · 4 comments

Comments

@jonathansampson
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Brave displays pinned tabs in ad-hoc popup windows. As a result, popup documents with a "Close window" link do not close the window, but rather than the active tab.

Expected behavior:
Popup windows should probably not show pinned tabs.

Platform: macOS/Windows

Brave Version (revision SHA): 0.13.0

Steps to reproduce:

  1. (With at least one pinned tab) Navigate to https://www.amazon.com/gp/navigation/redirector.html
  2. Click "Details" link
  3. In popup, click "Close window"
@bbondy
Copy link
Member

bbondy commented Dec 31, 2016

Moving to .13.1 because I think this has been there always and we're only accepting introduced from .12.15 regressions at this point for this release.

@bbondy bbondy modified the milestones: 0.13.1, 0.13.0 Dec 31, 2016
@jonathansampson jonathansampson changed the title "Close window" links don't work when tabs are pinned Pinned Tabs are Present in all Windows Jan 8, 2017
@jonathansampson
Copy link
Collaborator Author

jonathansampson commented Jan 8, 2017

+1 from Twitter:

Alan Plum @lnplum
Pain points after 1 day of @brave

  • pinned tabs are reopened in all windows
  • freeze on reopening w 20 tabs but YT autoplays w no way 2 stop

Source: https://twitter.com/lnplum/status/817861336088637440

Alan Plum ‏@lnplum
Opening pinned tabs in new windows (=2x @skype / @Trello / @slack / etc) is a deal-breaker for me, the > freezes are just an annoyance. @brave

Source: https://twitter.com/lnplum/status/817862786957115392

@darkdh
Copy link
Member

darkdh commented Jan 25, 2017

+1 from me because it is painful for oauth popup window.
it will slow down oauth tab loading when pinned tabs are loading simultaneously.

@darkdh darkdh self-assigned this Jan 25, 2017
@darkdh darkdh modified the milestones: 0.13.0, 0.13.1 Jan 25, 2017
@darkdh
Copy link
Member

darkdh commented Jan 25, 2017

This is actually regression
Popup window don't show pinned tab in 0.12.15
Try http://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_win_open5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.