Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 50/50 experiment for binary name spoofing in GPU process. #578

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Added 50/50 experiment for binary name spoofing in GPU process. #578

merged 1 commit into from
Apr 13, 2023

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Apr 4, 2023 •
edited
Loading

Resolves #579

ModuleFileNamePatch feature.

@boocmp boocmp requested a review from iefremov April 4, 2023 13:41
@boocmp boocmp requested a review from a team as a code owner April 4, 2023 13:41
kjozwiak
kjozwiak approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging so QA can run through the above on main (staging) before pushing the above via production.

@kjozwiak kjozwiak merged commit 750dcab into main Apr 13, 2023
@kjozwiak kjozwiak deleted the module_file_name_patch branch April 13, 2023 03:24
@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2023 •
edited
Loading

Hmmm looks like we'll have issues with "min_version": "112.1.52.15" as beta is currently 1.51.x which means the beta version will never be added into the ModuleFileNamePatchStudy study. This is fine if we're going to wait till 1.52.x makes it to beta however, brave/brave-core#17671 is currently in 1.51.x. I'll run through the Nightly cases for now and will wait till the above gets updated to check beta unless it's expected.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2023 •
edited
Loading

Desktop verifications on Nightly

Win 11 x64 Test Cases

ModuleFileNamePatchStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.52.37 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Basically used the STR/Cases outlined via brave/brave-core#17671 (comment).

  • launched 1.52.37 Chromium: 112.0.5615.49 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy:Enabled via brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to chrome.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\chrome.exe
GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\chrome.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\chrome.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\chrome.exe
Example Example Example
enabled1 enabled2 enabled3

ModuleFileNamePatchStudy:Default

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.52.37 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Basically used the STR/Cases outlined via brave/brave-core#17671 (comment).

  • launched 1.52.37 Chromium: 112.0.5615.49 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy:Default via brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to brave.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe
GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser-Nightly\Application\brave.exe
Example Example Example
default1 default2 default3

Desktop verifications on Beta

Win 11 x64 Test Cases

ModuleFileNamePatchStudy:Enabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.51.94 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
-- | --
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Basically used the STR/Cases outlined via brave/brave-core#17671 (comment).

  • launched 1.51.94 Chromium: 112.0.5615.121 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy:Enabled via brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to chrome.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\chrome.exe GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\chrome.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\chrome.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\chrome.exe
Example Example Example
image image image

ModuleFileNamePatchStudy:Default

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.51.94 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
-- | --
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Basically used the STR/Cases outlined via brave/brave-core#17671 (comment).

  • launched 1.51.94 Chromium: 112.0.5615.121 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy:Default via brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to brave.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\brave.exe
GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\brave.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\brave.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\brave.exe
Example Example Example
image image image

Desktop verifications on Release

Win 11 x64 Test Cases

ModuleFileNamePatchStudy (shouldn't bet appearing due to not meeting channel requirements)

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.119 Chromium: 112.0.5615.121 (Official Build) (64-bit)
-- | --
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Basically used the STR/Cases outlined via brave/brave-core#17671 (comment).

  • launched 1.50.119 Chromium: 112.0.5615.121 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy isn't appearing under brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to brave.exe

image

This was referenced Apr 17, 2023
Merged
Merged
Closed
@kjozwiak kjozwiak mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@iefremov iefremov iefremov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable ModuleFileNamePatch feature in Nightly&Beta on 50/50
3 participants
@boocmp @kjozwiak @iefremov