-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled ModuleFileNamePatch on Release channel. #1143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Test Seed Generated SuccessfullyTo apply the test seed:
Seed Details
|
1f82781
to
30b3124
Compare
kjozwiak
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Merging into main
so QA can verify before pushing #1144 into production
.
|
Example |
Example |
---|---|
![]() |
![]() |
ModuleFileNamePatchStudy:Default
- launched
1.68.131 Chromium: 127.0.6533.73
using the terminal/CLI switchbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
ModuleFileNamePatchStudy
wasn't being displayed viabrave://version
- restarted the browser and ensured that
ModuleFileNamePatchStudy:Enabled
viabrave://version
- checked
brave://gpu
and ensured that all the paths underExecutable path
are pointing tobrave.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Example |
Example |
---|---|
![]() |
![]() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.