Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled ModuleFileNamePatch on Release channel. #1143

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Enabled ModuleFileNamePatch on Release channel. #1143

merged 1 commit into from
Jul 29, 2024

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Jul 25, 2024

No description provided.

@boocmp boocmp self-assigned this Jul 25, 2024
@boocmp boocmp requested a review from a team as a code owner July 25, 2024 06:32
Copy link
Contributor

github-actions bot commented Jul 25, 2024

✅ Test Seed Generated Successfully

To apply the test seed:

  1. Desktop: Launch the browser with --variations-pr=1143.
    Android: Set the command line to --variations-pr=1143 in debug menu, restart the browser.
    iOS: Set Variations PR to 1143 in Brave Core Switches debug menu, restart the browser.
  2. Wait 5-10 seconds to fetch the seed.
  3. Restart the browser to apply the seed.
  4. Ensure Active Variations section at brave://version starts with the expected seed version (see below).

Seed Details

  • Version: pull/1143@431c83495ff38ea31c9824c4038d7f70b95e2d5c
  • Uploaded: 2024-07-25T16:11:26.889Z
  • Serial Number: abaaebb1697890e1915fb95497e8ec42

@boocmp boocmp force-pushed the issues/1142 branch 2 times, most recently from 1f82781 to 30b3124 Compare July 25, 2024 16:08
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into main so QA can verify before pushing #1144 into production.

@kjozwiak kjozwiak added this pull request to the merge queue Jul 29, 2024
@kjozwiak kjozwiak removed this pull request from the merge queue due to a manual request Jul 29, 2024
@kjozwiak kjozwiak merged commit ea8148f into main Jul 29, 2024
7 checks passed
@kjozwiak kjozwiak deleted the issues/1142 branch July 29, 2024 19:53
@kjozwiak
Copy link
Member

kjozwiak commented Jul 29, 2024

Win x64 verification

Using the same STR/Cases outlined via #578 (comment).

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.131 Chromium: 127.0.6533.73 (Official Build) (64-bit)
-- | --
Revision | 8167dd98e054f33ff258260aaf64d2eba8110772
OS | Windows 11 Version 23H2 (Build 22631.3958)

ModuleFileNamePatchStudy:Enabled

  • launched 1.68.131 Chromium: 127.0.6533.73  using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy:Enabled via brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to chrome.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser\Application\chrome.exe
GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser\Application\chrome.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser\Application\chrome.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser\Application\chrome.exe
Example Example
image image

ModuleFileNamePatchStudy:Default

  • launched 1.68.131 Chromium: 127.0.6533.73  using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that ModuleFileNamePatchStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that ModuleFileNamePatchStudy:Enabled via brave://version
  • checked brave://gpu and ensured that all the paths under Executable path are pointing to brave.exe
GetModuleFileNameExA = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
GetModuleFileNameExW = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
GetModuleFileNameA = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
GetModuleFileNameW = C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Example Example
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants