Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltips to show at the page load #7862

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Feb 8, 2021

Resolves brave/brave-browser#13995 & brave/brave-browser#14040

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 8, 2021
@deeppandya deeppandya added this to the 1.22.x - Nightly milestone Feb 8, 2021
@deeppandya deeppandya self-assigned this Feb 8, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 3feb6e7 into master Feb 8, 2021
@deeppandya deeppandya deleted the show_tooltips_on_page_load_android branch February 8, 2021 20:45
brave-builds pushed a commit that referenced this pull request Feb 8, 2021
brave-builds pushed a commit that referenced this pull request Feb 8, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2021

Verification passed on OnePlus 6T with Android 10 running 1.22.11 x64 Nightly build

  • Verified tooltips only show up after page is loaded
  • Verified tooltips are not stacked on one another
  • Verified tooltips are aligned correctly in both portrait and landscape mode

Portrait

image image image image

Landscape

image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes educational modal is shown even before page is loaded
3 participants