-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle "Allow in private" for Crypto Wallet and Greaselion #7579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Please just make sure that existing data is preserved before merging.
verified migrate from component extension to normal extension, the ETH from faucet on testnet is still there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ looks good to me, confirmed no data loss
8ff9e2c
to
6bbdfb1
Compare
This PR should also try to fix brave/brave-browser#13535 |
Handle "Allow in private" for Crypto Wallet and Greaselion
Resolves brave/brave-browser#13279
Resolves brave/brave-browser#13506
This PR
(https://developer.chrome.com/docs/extensions/mv2/manifest/incognito/#not_allowed)
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan:
Crypto Wallet
--show-component-extenstion-options
Allow in private
option is available and disabled by defaultCrypto Wallet: dApp
--show-component-extenstion-options
Crypto Wallet: Migration
Greaselion
--show-component-extenstion-options
Allow in private
option because it is off by default and can not be toggled on