Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Brave Ads crash querying database - 1.18.x HF1 #7444

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fixes Brave Ads crash querying database - 1.18.x HF1 #7444

merged 1 commit into from
Dec 17, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 15, 2020 •
edited by kjozwiak
Loading

Uplift of #7314
Resolves brave/brave-browser#12993

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.18.x - Release #2 milestone Dec 15, 2020
@tmancey tmancey requested a review from a team December 15, 2020 17:46
@tmancey tmancey self-assigned this Dec 15, 2020
@kjozwiak
Copy link
Member

Restarted pre-init via https://ci.brave.com/job/pr-brave-browser-issues-12993-1.18.x-pre-init/2/ as it failed to pull source as per https://ci.brave.com/job/pr-brave-browser-issues-12993-1.18.x-pre-init/1/flowGraphTable/.

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-issues-12993-1.18.x-windows/3/ due to init failing as per https://ci.brave.com/job/pr-brave-browser-issues-12993-1.18.x-windows/1/execution/node/134/log/.

Restarting iOS via https://ci.brave.com/job/pr-brave-browser-issues-12993-1.18.x-ios/2/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-issues-12993-1.18.x-ios/1/execution/node/138/log/.

13:18:39  FAILED: obj/net/net/crl_set.o

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Dec 16, 2020
@tmancey tmancey force-pushed the issues/12993-1.18.x branch from b4400fc to 8d6d552 Compare December 16, 2020 19:47
kjozwiak
kjozwiak approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7314 (comment).

@kjozwiak kjozwiak merged commit f51dbae into 1.18.x Dec 17, 2020
@kjozwiak kjozwiak deleted the issues/12993-1.18.x branch December 17, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Milestone
1.18.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak