Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Brave Ads crash querying database #7314

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Fixes Brave Ads crash querying database #7314

merged 1 commit into from
Dec 4, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 2, 2020

Resolves brave/brave-browser#12993

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#12993

@tmancey tmancey self-assigned this Dec 2, 2020
@tmancey tmancey force-pushed the issues/12993 branch 3 times, most recently from 1c60bd0 to 4843db1 Compare December 2, 2020 17:02
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kjozwiak
Copy link
Member

Verification PASSED on macOS 11.0.1 using the following build:

Brave | 1.20.36 Chromium: 88.0.4315.5 (Official Build) nightly (x86_64)
--- | ---
Revision | d2abe4588adaeb0d66aa0a0106675be1dff12c64-refs/branch-heads/4315@{#11}
OS | macOS Version 11.0.1 (Build 20B29)

Verification notes can be found via https://github.com/brave/internal/issues/741#issuecomment-747280348.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Ads crash querying database
4 participants