Fix deps in //brave/browser/importer #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae04f15 to
c938d11
Compare
bridiver
reviewed
Sep 21, 2020
| "task_manager/sampling/shared_sampler_posix.cc", | ||
| ] | ||
| } | ||
| + sources += brave_chrome_browser_importer_sources |
There was a problem hiding this comment.
since this is all part of //chrome/browser we don't want individual patches here. Please add //brave/browser/sources.gni (which will include //brave/browser/importer/sources.gni and do
brave_chrome_browser_sources = []
brave_chrome_browser_sources += brave_chrome_browser_importer_sources
and then change this patch to sources += brave_chrome_browser_sources
There was a problem hiding this comment.
ok, fixed like that.
e5e125e to
551c09c
Compare
bridiver
reviewed
Sep 24, 2020
| "task_manager/sampling/shared_sampler_posix.cc", | ||
| ] | ||
| } | ||
| + sources += brave_chrome_browser_sources |
There was a problem hiding this comment.
As we talked on slack, I add the deps as well.
04f12d3 to
f31664b
Compare
d9678cf to
7421f9f
Compare
Below files have a strong dependency with chrome/browser. So, this PR adds sources.gni to //brave/browser/importer and //brave/browser/sources.gni, then make //brave/browser/sources.gni include //brave/browser/importer/sources.gni, finally build //brave/browser/sources.gni in //chrome/browser. - brave_external_process_importer_client.cc - brave_external_process_importer_client.h - brave_external_process_importer_host.cc - brave_external_process_importer_host.h - brave_in_process_importer_bridge.cc - brave_in_process_importer_bridge.h Resolves brave/brave-browser#11752.
7421f9f to
3f71361
Compare
bridiver
approved these changes
Sep 25, 2020
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below files have a strong dependency with chrome/browser.
So, this PR adds sources.gni to //brave/browser/impoprter,
then make it build in //chrome/browser.
Resolves brave/brave-browser#11752.
Resolves
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.