Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fix deps in //brave/browser/importer/* #11752

Closed
Gyuyoung opened this issue Sep 17, 2020 · 0 comments · Fixed by brave/brave-core#6664
Closed

[Desktop] Fix deps in //brave/browser/importer/* #11752

Gyuyoung opened this issue Sep 17, 2020 · 0 comments · Fixed by brave/brave-core#6664

Comments

@Gyuyoung
Copy link

$ gn check . //brave/browser/importer/*

ERROR at //brave/browser/importer/brave_in_process_importer_bridge.cc:8:11: Include not allowed.
#include "chrome/browser/importer/profile_writer.h"
          ^---------------------------------------
It is not in any dependency of
  //brave/browser/importer:importer
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/importer/brave_in_process_importer_bridge.h:11:11: Can't include this header from here.
#include "brave/common/importer/brave_importer_bridge.h"
          ^--------------------------------------------
The target:
  //brave/browser/importer:importer
is including a file from the target:
  //brave/common/importer:importer

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //brave/browser/importer:importer -->
  //brave/common:common --[private]-->
  //brave/common/importer:importer

___________________
ERROR at //brave/browser/importer/brave_in_process_importer_bridge.h:12:11: Include not allowed.
#include "chrome/browser/importer/in_process_importer_bridge.h"
          ^---------------------------------------------------
It is not in any dependency of
  //brave/browser/importer:importer
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/importer/brave_external_process_importer_host.h:12:11: Include not allowed.
#include "chrome/browser/importer/external_process_importer_host.h"
          ^-------------------------------------------------------
It is not in any dependency of
  //brave/browser/importer:importer
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/importer/brave_external_process_importer_client.h:14:11: Include not allowed.
#include "chrome/browser/importer/external_process_importer_client.h"
          ^---------------------------------------------------------
It is not in any dependency of
  //brave/browser/importer:importer
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/importer/brave_external_process_importer_client.cc:12:11: Include not allowed.
#include "chrome/browser/service_sandbox_type.h"
          ^------------------------------------
It is not in any dependency of
  //brave/browser/importer:importer
The include file is in the target(s):
  //chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/importer/brave_external_process_importer_host.cc:17:11: Can't include this header from here.
#include "brave/common/importer/chrome_importer_utils.h"
          ^--------------------------------------------
The target:
  //brave/browser/importer:importer
is including a file from the target:
  //brave/common/importer:importer

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //brave/browser/importer:importer -->
  //brave/common:common --[private]-->
  //brave/common/importer:importer

___________________
ERROR at //brave/browser/importer/brave_external_process_importer_host.cc:18:11: Can't include this header from here.
#include "brave/common/importer/importer_constants.h"
          ^-----------------------------------------
The target:
  //brave/browser/importer:importer
is including a file from the target:
  //brave/common/importer:importer

It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //brave/browser/importer:importer -->
  //brave/common:common --[private]-->
  //brave/common/importer:importer

___________________
ERROR at //brave/browser/importer/brave_external_process_importer_host.cc:21:11: Include not allowed.
#include "chrome/browser/extensions/webstore_install_with_prompt.h"
          ^-------------------------------------------------------
It is not in any dependency of
  //brave/browser/importer:importer
The include file is in the target(s):
  //chrome/browser/extensions:extensions
which should somehow be reachable.

@Gyuyoung Gyuyoung added this to the 1.16.x - Nightly milestone Sep 17, 2020
Gyuyoung added a commit to brave/brave-core that referenced this issue Sep 18, 2020
Below files have a strong dependency with chrome/browser.
So, this PR adds sources.gni to //brave/browser/impoprter,
then make it build in //chrome/browser.

  - brave_external_process_importer_client.cc
  - brave_external_process_importer_client.h
  - brave_external_process_importer_host.cc
  - brave_external_process_importer_host.h
  - brave_in_process_importer_bridge.cc
  - brave_in_process_importer_bridge.h

Resolves brave/brave-browser#11752.
Gyuyoung added a commit to brave/brave-core that referenced this issue Sep 22, 2020
Below files have a strong dependency with chrome/browser.
So, this PR adds sources.gni to //brave/browser/importer
and //brave/browser/sources.gni, then make
//brave/browser/sources.gni include //brave/browser/importer/sources.gni,
finally build //brave/browser/sources.gni in //chrome/browser.

  - brave_external_process_importer_client.cc
  - brave_external_process_importer_client.h
  - brave_external_process_importer_host.cc
  - brave_external_process_importer_host.h
  - brave_in_process_importer_bridge.cc
  - brave_in_process_importer_bridge.h

Resolves brave/brave-browser#11752.
Gyuyoung added a commit to brave/brave-core that referenced this issue Sep 25, 2020
Below files have a strong dependency with chrome/browser.
So, this PR adds sources.gni to //brave/browser/importer
and //brave/browser/sources.gni, then make
//brave/browser/sources.gni include //brave/browser/importer/sources.gni,
finally build //brave/browser/sources.gni in //chrome/browser.

  - brave_external_process_importer_client.cc
  - brave_external_process_importer_client.h
  - brave_external_process_importer_host.cc
  - brave_external_process_importer_host.h
  - brave_in_process_importer_bridge.cc
  - brave_in_process_importer_bridge.h

Resolves brave/brave-browser#11752.
deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
Below files have a strong dependency with chrome/browser.
So, this PR adds sources.gni to //brave/browser/importer
and //brave/browser/sources.gni, then make
//brave/browser/sources.gni include //brave/browser/importer/sources.gni,
finally build //brave/browser/sources.gni in //chrome/browser.

  - brave_external_process_importer_client.cc
  - brave_external_process_importer_client.h
  - brave_external_process_importer_host.cc
  - brave_external_process_importer_host.h
  - brave_in_process_importer_bridge.cc
  - brave_in_process_importer_bridge.h

Resolves brave/brave-browser#11752.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant