-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Fix deps in //brave/browser/importer/* #11752
Milestone
Comments
32 tasks
Gyuyoung
added a commit
to brave/brave-core
that referenced
this issue
Sep 18, 2020
Below files have a strong dependency with chrome/browser. So, this PR adds sources.gni to //brave/browser/impoprter, then make it build in //chrome/browser. - brave_external_process_importer_client.cc - brave_external_process_importer_client.h - brave_external_process_importer_host.cc - brave_external_process_importer_host.h - brave_in_process_importer_bridge.cc - brave_in_process_importer_bridge.h Resolves brave/brave-browser#11752.
Gyuyoung
added a commit
to brave/brave-core
that referenced
this issue
Sep 22, 2020
Below files have a strong dependency with chrome/browser. So, this PR adds sources.gni to //brave/browser/importer and //brave/browser/sources.gni, then make //brave/browser/sources.gni include //brave/browser/importer/sources.gni, finally build //brave/browser/sources.gni in //chrome/browser. - brave_external_process_importer_client.cc - brave_external_process_importer_client.h - brave_external_process_importer_host.cc - brave_external_process_importer_host.h - brave_in_process_importer_bridge.cc - brave_in_process_importer_bridge.h Resolves brave/brave-browser#11752.
Gyuyoung
added a commit
to brave/brave-core
that referenced
this issue
Sep 25, 2020
Below files have a strong dependency with chrome/browser. So, this PR adds sources.gni to //brave/browser/importer and //brave/browser/sources.gni, then make //brave/browser/sources.gni include //brave/browser/importer/sources.gni, finally build //brave/browser/sources.gni in //chrome/browser. - brave_external_process_importer_client.cc - brave_external_process_importer_client.h - brave_external_process_importer_host.cc - brave_external_process_importer_host.h - brave_in_process_importer_bridge.cc - brave_in_process_importer_bridge.h Resolves brave/brave-browser#11752.
deeppandya
pushed a commit
to brave/brave-core
that referenced
this issue
Oct 7, 2020
Below files have a strong dependency with chrome/browser. So, this PR adds sources.gni to //brave/browser/importer and //brave/browser/sources.gni, then make //brave/browser/sources.gni include //brave/browser/importer/sources.gni, finally build //brave/browser/sources.gni in //chrome/browser. - brave_external_process_importer_client.cc - brave_external_process_importer_client.h - brave_external_process_importer_host.cc - brave_external_process_importer_host.h - brave_in_process_importer_bridge.cc - brave_in_process_importer_bridge.h Resolves brave/brave-browser#11752.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$ gn check . //brave/browser/importer/*
The text was updated successfully, but these errors were encountered: