Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable card benefits features #27777

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Feb 24, 2025

Resolves brave/brave-browser#44091

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Feb 24, 2025
@emerick emerick requested a review from a team as a code owner February 24, 2025 16:29
@emerick emerick requested a review from mkarolin February 24, 2025 16:29
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Feb 24, 2025
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick merged commit 240cd27 into master Feb 24, 2025
19 checks passed
@emerick emerick deleted the emerick-disable-card-benefits-features branch February 24, 2025 20:34
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 24, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.63

@LaurenWags
Copy link
Member

LaurenWags commented Feb 25, 2025

Verified with

Brave | 1.77.64 Chromium: 134.0.6998.24 (Official Build) nightly (x86_64)
-- | --
Revision | 0d8dca4c634de72e973731be2df712603e657373
OS | macOS Version 14.7.4 (Build 23H420)

Using 1.77.61 Chromium: 134.0.6998.24 and STR from issue, reproduced the setting being displayed and the link nav:

61.mov

Using 1.77.64 Chromium: 134.0.6998.24 and same STR, confirmed the setting is not displayed:

64

Using a test AMEX cc number, confirmed no additional UI displayed when attempting a checkout flow:

Screenshot 2025-02-25 at 1 24 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CR134] - Disable Card benefits feature/setting in brave://settings/payments
4 participants