Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR134] - Disable Card benefits feature/setting in brave://settings/payments #44091

Closed
1 of 6 tasks
GeetaSarvadnya opened this issue Feb 19, 2025 · 3 comments · Fixed by brave/brave-core#27777
Closed
1 of 6 tasks
Assignees
Labels

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 19, 2025

Description

Found while testing #43213

Click on Learn about card benefits redirects to Chrome support page.

The Card benefits feature should be fully disabled, thus hiding/removing this setting and the link that goes to the Chrome support page.

Steps to reproduce

  1. Clean profile 1.77.51 CR134
  2. Open brave://settings/payments
  3. Click on Learn about card benefits link

Actual result

Click on Learn about card benefits redirects to Chrome support page

Image

Expected result

The link should not redirect to chrome support page

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.77.51 Chromium: 134.0.6998.15 (Official Build) nightly (64-bit)
Revision 3dc8988df83ca503fd82dccd03a052e9ca94d8a4
OS Windows 10 Version 22H2 (Build 19045.5487)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @rebron @emerick

@emerick
Copy link
Contributor

emerick commented Feb 24, 2025

Spoke with @rebron and we want to hide the "Card benefits" row on this page and disable the corresponding feature.

@rebron rebron changed the title CR134 - Click on Learn about card benefits redirects to Chrome support page [CR134] - Disable Carb benefits feature/setting in brave://settings/payments Feb 24, 2025
@rebron rebron changed the title [CR134] - Disable Carb benefits feature/setting in brave://settings/payments [CR134] - Disable Carn benefits feature/setting in brave://settings/payments Feb 24, 2025
@rebron rebron changed the title [CR134] - Disable Carn benefits feature/setting in brave://settings/payments [CR134] - Disable Card benefits feature/setting in brave://settings/payments Feb 24, 2025
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 24, 2025
@rebron rebron moved this to In progress in Settings Feb 24, 2025
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 24, 2025
@LaurenWags
Copy link
Member

Requires 1.76.69 or higher for verification 👍🏻

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 27, 2025
@LaurenWags
Copy link
Member

LaurenWags commented Feb 27, 2025

Verified with

Brave | 1.76.69 Chromium: 134.0.6998.24 (Official Build) beta (x86_64)
-- | --
Revision | 55ecc732897c3be718a5d828607782d3c54a2271
OS | macOS Version 14.7.4 (Build 23H420)

Confirmed "Card benefits" option is not displayed under brave://settings/payments:

Image

Using a test AMEX cc number, confirmed no additional UI displayed when attempting a checkout flow:

Image

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

7 participants