Upgrade from Chromium 133 to Chromium 134

[emerick]

Description

Upgrade from Chromium 133 to Chromium 134

https://chromium.googlesource.com/chromium/src/+log/133.0.6943.3..134.0.6944.2/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Tab-related functionality (tab grouping, dragging tabs, tab search, vertical tabs, etc.)
• Search engine selection/default search
• Creating/using a new profile
• Bookmarks bar
• Side panel
• Split view functionality
• Brave wallet

iOS Affected areas:

• Nothing of particular note

Android Affected areas:

1. Ensure at Delete browsing data settings there are Leo AI and Clear Brave Ads data... items.
2. Ensure bottom toolbar is on the bottom and can be turned off.
3. Ensure that quick search engines settings are saved/restored.
4. Ensure that change of DSE works in a normal and in a private tab.
5. Ensure that export/import bookmarks works.
6. Play YT links in browser should work.
7. Ensure that Autofill works.
8. Ensure that webpush notifications work doesn't work now - working on the fix - fixed at [Android] Fixed permission_dialog_delegate_ at PermissionPromptAndroid brave-core#27715

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.77.51 Chromium: 134.0.6998.15 (Official Build) nightly (64-bit)
-- | --
Revision | 3dc8988df83ca503fd82dccd03a052e9ca94d8a4
OS | Windows 10 Version 22H2 (Build 19045.5487)

• Logged [CR134] - Disable Card benefits feature/setting in brave://settings/payments #44091
• Logged Developer tool, Task manager, Reading list, New private window, Print and Copy link customize toolbar icons are NOT Brave branded #44115
• Logged Customize toolbar graphics shows the chrome toolbar icons #44114
• Logged Click on Brave is managing your new tab page via customize toolbar settings menu redirects to brave://settings/search page #44117
• Logged Crash when drag and drop a split view tab #44150
• Logged An existing tab can be dragged in between the split view and split focus is highlighted for all the three tabs #44151
• Logged dragging an existing tab on the tab bar will also drag a split view if the Split view is present before or after the tab #44153
• Logged when a split view is dragged into a tab group the extra tab gets dragged and same gets pinned when a split view is pinned #44155

Tab-related functionality (tab grouping, dragging tabs, tab search, vertical tabs, etc.)_PASSED

Tab search:

• Confirmed that all the opened/closed tabs are opened via Tab search panel
• Confirmed that user can see recently closed tabs via Tab search panel
• Confirmed that user can search specific site via Tab search panel
• Confirmed that user can close the specific tab via Tab search panel

Vertical tabs:

1. Pin and unpin tab
2. Drag and drop a tab on tab bar
3. Create a tab group
4. Add a new/existing tab to new/existing tab group
5. Tearing tab from tab bar and tab group
6. Tab hover affect

Horizonal Tabs:

1. Pin and unpin tab
2. Drag and drop a tab on tab bar
3. Create a tab group
4. Add a new/existing tab to new/existing tab group
5. Tearing tab from tab bar and tab group
6. Tab hover affect

Search engine selection/default search_PASSED

Case 1: New user from Brave Search default SE target country (India)_PASSED

1. Clean profile 1.77.x
2. Check Brave is the default SE via brave://settings/search for both Normal and Private windows
3. Check that Change button is shown next to default SE for Normal window search settings
4. Click on Change button and ensured that list of SE's displayed in the dropdown
5. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
6. Check search suggestions option is enabled by default in brave://settings/search
7. Confirmed brave search suggestions are shown when typing into the omnibox

Case 2: Existing user from Brave Search default SE target country (India)_default search settings not modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Check Brave is the default SE via brave://settings/search
3. Check search suggestions option is enabled by default in brave://settings/search
4. Upgrade the profile to 1.77.x
5. Check that Change button is shown next to default SE for Normal window search settings
6. Click on Change button and ensured that list of SE's displayed in the dropdown
7. Confirmed that Brave radio button is selected and is in the first place in the search engine dropdown
8. Confirm brave search suggestions are shown when typing into the omnibox

Case 3: Existing user from Brave Search default SE target country (India)_default search settings modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Check Brave is the default SE via brave://settings/search
3. Check search suggestions option is enabled by default in brave://settings/search
4. Change the default SE to Bing or any SE other than Brave in both Normal and PT
5. Upgrade the profile to 1.77.x
6. Check that Bing is the default SE in both Normal and PT windows and Change button is shown next to default SE for Normal window
7. Click on Change button and ensured that list of SE's displayed in the dropdown
8. Confirmed that Brave is first SE in the dropdown
9. Confirm Bing search suggestions are shown when typing into the omnibox
10. Change the Search engine to Google and click on Set as default
11. Confirmed default SE is set to Google in Normal windows
12. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner

Case 4: New user from outside brave search target country (Cuba)_PASSED

1. Clean profile 1.77.x
2. Open brave://settings/search and ensured that Google is the default SE
3. Confirmed that Change button is shown next to default SE for Normal window SE settings
4. Click on Change button and ensured that list of SE's displayed in the dropdown
5. Confirmed that Google SE radio button is selected
6. Confirmed that Brave is first SE in the dropdown
7. Confirmed that Show search suggestion settings is disabled as expected
8. Confirm Google search suggestions are shown when typing into the omnibox

Case 5: New user from outside brave search target country (Cuba)_default search settings not modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Open brave://settings/search and ensured that Google is the default SE
3. Upgrade the profile to 1.77.x
4. Open brave://settings/search and ensured that Google is the default SE
5. Confirmed that Change button is shown next to default SE for Normal window SE settings
6. Click on Change button and ensured that list of SE's displayed in the dropdown
7. Confirmed that Google SE radio button is selected
8. Confirmed that Brave is first SE in the dropdown
9. Confirmed that Show search suggestion settings is disabled as expected
10. Confirm Google search suggestions are shown when typing into the omnibox along with Brave search promo banner

Case 6: Existing user from outside brave search target country (Cuba)_default search settings modified prior upgrade_PASSED

1. Clean profile 1.75.x
2. Open brave://settings/search and ensured that Google is the default SE
3. Change the default SE to any SE other than Google (I have changed SE to StartPage)
4. Upgrade the profile to 1.77.x
5. Open brave://settings/search and ensured that StartPage is the default SE
6. Confirmed that Change button is shown next to default SE for Normal window SE settings
7. Click on Change button and ensured that list of SE's displayed in the dropdown
8. Confirmed that StartPage SE radio button is selected
9. Confirmed that Brave is first SE in the dropdown
10. Confirmed that Show search suggestion settings is disabled as expected
11. Confirm StartPage search suggestions are shown when typing into the omnibox along with Brave search promo banner

Creating/using a new profile_PASSED

• Confirmed that user can create a new profile by using Add new profile menu option via hamburger menu
• Confirmed that user can switch to different profile via profile picker menu
• Confirmed that user can ADD/Edit/Delete the profiles via Profile manager
• Confirmed that user can open the Guest window using Open Guest profile option via profile picker
• Open few sites and update the brave://settings in Profile 1 and ensure that the change made in profile 1 aren't reflected in other profiles

Example	Example	Example	Example

Bookmarks bar_PASSED

• Confirmed that bookmarks are shown on the bookmarks bar when show bookmarks always option is selected
• Confirmed that bookmarks bar is shown on the NTP
• Confirmed that bookmarks cab be drag and dropped on the bookmarks bar
• Confirmed that bookmarks bar is shown on the Private and Private window with Tor tabs
• Confirmed that tab groups are shown on the bookmarks bar by default

Side panel_PASSED

Bookmarks

• Confirmed that imported bookmarks are listed under Bookmarks tab under the side panel
• Confirmed that bookmarks can be sorted from A-Z and Z-A
• Confirmed that bookmarks can be added/deleted
• Confirmed that bookmarks folders can be added via Bookmarks side panel option
• Confirmed that bookmarks can be viewed in compact/visual view

Reading list

• Confirmed that user can add open tab/sites to the reading list using Add tab to the reading list option
• Confirmed that tabs added to the reading list are shown under reading list sidebar panel
• Confirmed that user can add the current tab to the reading list by clicking on Add current tab option via reading list sidebar panel
• Confirmed that user delete the added sites from reading list by clicking on the x or close button
• Confirmed that user can expand/collapse the reading list sites
• Confirmed that user can segregate the reading list tabs/site to read/unread

Leo AI, Brave Talk, wallet and playlist:

• Confirmed that click on Leo AI via sidebar panel opens up the Leo chat window, and user can ask questions via Leo AI and answers are given by Leo AI as expected
• Confirmed that click on wallet via sidebar panel opens up the create brave wallet page as expected
• Confirmed that click on Brave talk via sidebar panel open up the Brave talk join meeting page
• Confirmed that click on Playlist via sidebar panel opens up the playlist panel and confirmed that user can add any video to the playlist

Split view functionality_PASSED

• Verified the test plan from Use proper bounding box for positioning SidebarShowOptionsEventDetectWidget brave-core#27553

Creating a Split View

1. Right click on a tab and check that New Split View is below Reload in the menu. Select New Split View. The selected tab should appear on the left and a new tab page should appear on the right. Focus should appear on the newly created split item. In the tab bar, the items in the split view should come together and look combined and the split in focus should be highlighted.

2. Open a web page of your choice that has a few links and right click on a link. Check that Open Link in Split View is below Open Link in Private Window with Tor. Select Open Link in Split View and the linked page should appear to the right of the existing page. Focus should appear on the newly created split item.

3. Select two tabs, and select Open in Split View. Ensure that both tabs are opened in split view of equal size within the window and the right side split is in focus.

4. Select two tabs like above but in three more variations, 1. Pinned tab and a normal tab. 2. Tabs within a group. 3. Tabs that are not adjacent to each other.

5. Repeat above steps in Vertical tab mode.

Unsplit Tabs

1. Right click on a split view tab and select Unsplit Tabs. Tabs should be unsplit and look like before and will be next to each other.
2. Have a split view open, and select the the Split view button in the middle of the split and select Unsplit Tabs. Tabs should be unsplit and look like before.

Closing a tab in split view

1. Closing a tab in split view should act like normal and close the tab, either by selecting the x or by shortcut. By closing a tab within a split view automatically unsplits the tab and the other tab should remain. Restoring that tab should only restore the tab and not the split.

Drag and Dropping a Split View

1. Have several tabs open and also have a split view. Select the split view tabs and drag and drop to different positions within a full tab bar.
2. From step 2 above, check that you can drag a split view into a tab group.
3. Select split view tabs and drag the split view out to create a new window with just the split view. Drag the split view items from the new window and ensure you can drag back into the original window or any other open window.

• logged Crash when drag and drop a split view tab #44150
• logged An existing tab can be dragged in between the split view and split focus is highlighted for all the three tabs #44151
• logged dragging an existing tab on the tab bar will also drag a split view if the Split view is present before or after the tab #44153

Known/expected:

1. When 2 split view tabs are adjacent, drag and drop 1st split view will drag 2nd split tab view as well 

2. When a split view tab is dragged to a new window, along with split view the tab that is present next to the split view will also be dragged to a new window 

3. Can we drag a new/existing tab in-between the split view tab? the split focus is highlighted for three tabs - This is expected https://bravesoftware.slack.com/archives/CKNHM4RTK/p1740141337822829?thread_ts=1739912894.037299&cid=CKNHM4RTK

4. When there are two split views on a tab bar (not adjacent, there few tabs in-between the two split views) add/remove a split view into a tab group will add/remove both split views - Is this expected?

Pinning/unpinning a Split View

1. Pin a split view by selecting the split view tab and right clicking to Pin. Ensure that Pinned split view shows focus when selecting one of the split view items.
2. Ensure you can Unpin a split view by right clicking either Pinned split view item.

• Encountered the issue Unpinning a split pinned tab removes the pin on original tab #44089
• Logged when a split view is dragged into a tab group the extra tab gets dragged and same gets pinned when a split view is pinned #44155

Resizing and Swapping Tab Positions

1. Right click on split tab and select Swap Tab Positions. Tab position should switch.
2. Select split view button in the middle of the screen and select Swap Tab Positions. Tabs positions should switch.
3. Hover over the separator (in the middle of the split) and the mouse pointer should turn into a resize pointer. Resize the window left and right and there should be a minimum width of the smaller window.

Appearance and security UI

1. When in a split view, check that the focused tab has a border around it and that the split tab in the tab bar is highlighted and also in focus.
2. Check that the unfocused tab shows the url of the page on the top left of the split view.
3. Select the tune/permissions button in the url bar and check that domain is the same as the focused tab.
4. Select the Shields button and check that domain is the same as the focused tab.

• Provided a suggestion on split view on dark mode via https://bravesoftware.slack.com/archives/CKNHM4RTK/p1740151592633749?thread_ts=1739912894.037299&cid=CKNHM4RTK
• Focus tab doesn't have border on a split view in an vertical tab orientation - Looks like known issue @rebron mentioned in the walkthrough

---

Settings comparison

• A new settings Card benefits added as part of CR134 via brave://settings/payments
  
• brave://settings headers are re-arranged and Brave Rewards is renamed to Rewards as part of Brave
  
• A new settings Customize brave is added via Hamburger menu as part of Brave (Reference issue Enable brave://flags/#toolbar-pinning by default #42467)
  
• A new settings Customize your toolbar is added as part of Enable brave://flags/#toolbar-pinning by default #42467
  

Customize your toolbar

1. Toolbar icons drag and drop:

• Confirmed that toolbar icons can be drag and drop to re-arrange the icons on the toolbar

2. Unpin/hide the toolbar icon:

• Confirmed that the toolbar icons can be unpin/hide by right clicking on the toolbar icon
• Confirmed that the toggle is turned off for the icon which is unpinned from the toolbar

3. Click on toolbar icons:

• Confirmed that click on the Reading list toolbar icon opens up the reading list in the side panel
• Confirmed that click on the Bookmark toolbar icon opens up the bookmarks in the side panel
• Confirmed that click on the Delete browsing data toolbar icon opens up the Delete browsing data panel
• Confirmed that click on the Print toolbar icon opens up the print view
• Confirmed that click on the Change your password toolbar icon opens up the password manger page
• Confirmed that click on the Payment method toolbar icon opens up the payment method page
• Confirmed that click on the Address and more toolbar icon opens up the address and more page
• Confirmed that click on the New private window toolbar icon opens up the private window
• Confirmed that click on the Developer toolbar icon opens up the developer tool console
• Confirmed that click on the Task manager toolbar icon opens up the task manager window
• Confirmed that click on the Copy link toolbar icon copy the site link from the URL bar
• Confirmed that click on the Create a QR code toolbar icon creates the QR code for the opened site
• Confirmed that click on the translate this page toolbar icon translate the non-English page

4. Toggle toolbar icons on and off via a customization side panel:

• Confirmed that when Navigation, Your Brave and Tools and actions toggles are turned ON, the toolbar icons are shown/pinned on the toolbar
• Confirmed that when Navigation, Your Brave and Tools and actions toggles are turned OFF, the toolbar icons are not shown/unpinned on the toolbar

Brave startup calls

• Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

[GeetaSarvadnya]

@srirambv Can you verify the desktop affected area item Brave wallet on 1.77.51 CR134 build?. Thanks!

[Uni-verse]

Verified on Samsung Galaxy S21 using version:

Brave	1.77.52 Chromium: 134.0.6998.15 (Official Build) canary (64-bit) 
Revision	d2b1e97cd8ae806f9aa05a0204a9b953536c5bce
OS	Android 14; Build/UP1A.231005.007; 34; REL

Delete browsing data

• Ensured that Leo AI and Clear Brave Ads data are shown in Delete Browsing Data settings
• Ensured that Reset Brave Rewards data.. CTA is will shown when Brave Rewards is enabled.
• Ensured that Leo data is cleared when selected.

example	example	example

Bottom toolbar

• Ensured that bottom toolbar is on the bottom and can be disabled in settings.
• Ensured top toolbar is working.

example	example	example

QSE settings

• Ensured Quick-Search Engine settings are saved when changing the toggles.
• Ensured that QSE settings are saved when toggling QSE bar setting.
• Ensured QSE settings are retained when upgrading app.

example	example	example

DSE in normal and private tab

• Ensured Default Search Engine works in normal and private tabs

example	example

Import/export bookmarks

• Ensured importing/exporting works

example	example	example

YouTube links in browser

• Ensured that playing YouTube links in the browser works.

example	example

Autofill

• Ensured autofill is working when email/pass is stored.

Webpush notifications

• Regression in Chromium 134 - Permissions for notification are not requested #44073

[srirambv]

Verification passed on

Brave	1.77.52 Chromium: 134.0.6998.15 (Official Build) nightly (64-bit)
Revision	d2b1e97cd8ae806f9aa05a0204a9b953536c5bce
OS	Windows 11 Version 24H2 (Build 26100.2894)

• Verified able to create new wallet
• Verified able to restore wallet from seed
• Verified able to connect Ledger/Trezor and import accounts
• Verified able to Approve and Send transactions from Ledger accounts
• Verified able to Retry/Cancel/Speedup transactions
• Verified able to load and add new NFTs
• Verified able to Swap/Bridge tokens
• Encountered #44118,#44119

[kjozwiak]

Labelling as QA/No & release-notes/exclude in favour of #44111.