Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #39305 Update package.json #24345

Conversation

KoushikBaagh
Copy link

@KoushikBaagh KoushikBaagh commented Jun 24, 2024

Update Chromium URL to SSH protocol in "package.json" script to prevent network errors during setup

Resolves

brave/brave-browser#39305

Proposed Solution

  • Replace the HTTPS URL with the SSH protocol URL:
    "url": "git@github.com:brave/chromium.git"
  • This simple change significantly improves the reliability of the initial setup process, especially for developers with slower internet connections or those behind certain network configurations.
  • This issue is a significant obstacle for new contributors trying to set up the Brave browser source code locally for the first time, potentially discouraging participation in the project.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Update Chromium URL to SSH protocol in "package.json" script to prevent network errors during setup
@KoushikBaagh KoushikBaagh requested a review from a team as a code owner June 24, 2024 10:44
@kdenhartog
Copy link
Member

In general, we don't allow outside contributors to modify these locked files. Could you open an issue for this instead and someone internally will make the update?

@KoushikBaagh
Copy link
Author

@kdenhartog , I have already created an issue
Link : brave/brave-browser#39305

Please do let me , if I can be of any more help .

@bsclifton
Copy link
Member

Closed parent issue as wontfix - work-around described in brave/brave-browser#39305 (comment)

@bsclifton bsclifton closed this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants