Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium URL to SSH protocol in "npm run init" script to prevent network errors during setup #39305

Closed
6 tasks
KoushikBaagh opened this issue Jun 24, 2024 · 1 comment
Labels
closed/wontfix OS/Android Fixes related to Android browser functionality

Comments

@KoushikBaagh
Copy link

KoushikBaagh commented Jun 24, 2024

Description

When setting up Brave browser locally for Android development in LINUX , the initialization script (npm run init) fails while fetching the Chromium source code. This is due to the large size of the Chromium repository (approximately 50GB) causing network issues.
Current Behavior:
The package.json file contains a URL for the Chromium repository using HTTPS:
json

"url": "https://github.com/brave/chromium"

This often results in timeout errors or incomplete downloads for users with slower or less stable internet connections.

Steps to reproduce

  1. After performing the initial steps:-

  2. git clone git@github.com:brave/brave-core.git path-to-your-project-folder/src/brave
    cd path-to-your-project-folder/src/brave
    npm install
    npm run init -- --target_os=android --target_arch=arm

Actual result

Screenshot (84)

Expected result

The result should look like 100% (done/done)

Reproduces how often

Easily reproduced

Brave version

NA

Device

  • Brand/model: NA
  • Android version: NA

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Observe that the process fails or times out while attempting to fetch the Chromium source code.

Check the console output for network-related errors or timeout messages.

Note: This issue is more likely to occur on slower or less stable internet connections.

@KoushikBaagh KoushikBaagh added the OS/Android Fixes related to Android browser functionality label Jun 24, 2024
@bsclifton
Copy link
Member

Hi @KoushikBaagh - apologies we never properly circled back here

To solve this, I would recommend modifying your local .gitconfig file. You can add the following lines in there at the end

[url "ssh://git@github.com/"]
insteadOf = https://github.com/

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

2 participants