Fix android test overrides #20825
Merged
Fix android test overrides #20825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
commented
Nov 3, 2023
| } | ||
|
|
||
| #if BUILDFLAG(IS_WIN) | ||
| // Enable high-DPI for interactive tests where the user is expected to | ||
| // Many tests validate code that requires user32.dll to be loaded. Loading it, |
There was a problem hiding this comment.
with the latest changes to chrome_test_launcher I think this file can be eliminated and replaced with upstream
There was a problem hiding this comment.
the changes here are pulled in from upstream
bbondy
approved these changes
Nov 7, 2023
goodov
reviewed
Nov 8, 2023
goodov
reviewed
Nov 8, 2023
| #endif // BUILDFLAG(IS_WIN) | ||
| } | ||
|
|
||
| ChromeTestSuiteRunner runner; | ||
| BraveTestLauncherDelegate delegate(&runner); |
There was a problem hiding this comment.
can you #define-override ChromeTestLauncherDelegate with BraveTestLauncherDelegate and just use browser_tests_runner from chrome?
both chromium and brave tests can use BraveTestLauncherDelegate, that should be fine.
There was a problem hiding this comment.
yes as mentioned here https://github.com/brave/brave-core/pull/20825/files#r1382007273 but I was leaving this for a follow-up because I want to get what I have here merged
There was a problem hiding this comment.
iefremov
reviewed
Nov 8, 2023
goodov
approved these changes
Nov 8, 2023
mkarolin
added a commit
that referenced
this pull request
May 1, 2024
The cause of failure for these tests was fixed in #20825.
mkarolin
added a commit
that referenced
this pull request
May 3, 2024
The cause of failure for these tests was fixed in #20825.
mkarolin
added a commit
that referenced
this pull request
May 3, 2024
The cause of failure for these tests was fixed in #20825.
mkarolin
added a commit
that referenced
this pull request
May 3, 2024
The cause of failure for these tests was fixed in #20825.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27837
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: