Skip to content

Commit

Permalink
Re-enable some upstream tests that used to fail.
Browse files Browse the repository at this point in the history
The cause of failure for these tests was fixed in
#20825.
  • Loading branch information
mkarolin committed May 3, 2024
1 parent 2ebc013 commit 40cdea0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
14 changes: 0 additions & 14 deletions test/filters/browser_tests-windows.filter
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,6 @@
-ServiceWorker/ExtensionWebRequestApiTestWithContextType.WebRequestRedirectsWorkers/BackgroundResourceFetchDisabled
-ServiceWorker/ExtensionWebRequestApiTestWithContextType.WebRequestRedirectsWorkers/BackgroundResourceFetchEnabled

# This test passes locally but fails on CI likely because BraveMainDelegate is
# available in the Chromium tests. It fails with the message:
#
# Terminating render process for bad Mojo message: Received bad user message:
# No binder found for interface brave_news.mojom.BraveNewsController for the
# frame/document scope
#
# The binder is not instantiated because BraveContentBrowserClient is also not
# available. The difference between CI and local execution has not been
# investigated.
-FetchManifestAndInstallCommandTest.MultipleInstalls
-WebAppStatusBarTest.DisplayBrowserHasStatusBar
-WebAppTabStripBrowserTest.OnlyNavigateHomeTabIfDifferentUrl

# These tests fail because our default search provider is not Google, which
# makes the page classification return the result the tests don't expect. Also,
# kZeroSuggestPrefetchingOnWeb feature is currently disabled by default which
Expand Down
6 changes: 0 additions & 6 deletions test/filters/browser_tests.filter
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,6 @@
-WebHidWebViewTest.PermissionsAPIEmbedderHasAccessCloseWindowHid
-WebHidWebViewTest.PermissionsAPIEmbedderHasAccessDenyHid

# This test fails with the message:
# Terminating render process for bad Mojo message: Received bad user message:
# No binder found for interface brave_news.mojom.BraveNewsController for the
# frame/document scope
-SearchEngineChoiceBrowserTest.DialogNotShownOverSpecificBrowserTypes

# These tests fail because we stub search_engines::IsChoiceScreenFlagEnabled to
# always return false
-SearchEngineChoiceDialogBrowserTest.*
Expand Down

0 comments on commit 40cdea0

Please sign in to comment.