Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Brave Private Ads resources after Brave Rewards reset #19522

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Aug 1, 2023

Resolves brave/brave-browser#32017

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Run Brave Browser with a fresh profile
  2. Make sure that flag is enabled on brave://flags (or enable it if not enabled):
    • brave-ads-should-always-run-brave-ads-service
  3. Make sure that Brave Ads are started (there should be logs in Brave Rewards Log)
  4. Make sure that the conversion resource resource is loaded: Successfully loaded nnqccijfhvzwyrxpxwjrpmynaiazctqb conversion resource log message in Rewards Logs
  5. Opt-in to Brave Rewards
  6. Reset Brave Rewards from the brave://rewards page
  7. Make sure that Brave Ads are re-started
  8. Make sure that the conversion resource resource is loaded

@aseren aseren requested a review from a team as a code owner August 1, 2023 19:07
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload Brave Private Ads resources after Brave Rewards reset
2 participants