Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload Brave Private Ads resources after Brave Rewards reset #32017

Closed
aseren opened this issue Aug 1, 2023 · 1 comment · Fixed by brave/brave-core#19522
Closed

Reload Brave Private Ads resources after Brave Rewards reset #32017

aseren opened this issue Aug 1, 2023 · 1 comment · Fixed by brave/brave-core#19522

Comments

@aseren
Copy link

aseren commented Aug 1, 2023

Need to reload Brave Private Ads resources after Brave Rewards reset only if brave-ads-should-always-run-brave-ads-service flag is enabled.

@aseren aseren self-assigned this Aug 1, 2023
@aseren aseren changed the title Handle Brave Private Ads state after Brave Rewards reset Load Brave Private Ads resources after Brave Rewards reset Aug 1, 2023
@aseren aseren changed the title Load Brave Private Ads resources after Brave Rewards reset Reload Brave Private Ads resources after Brave Rewards reset Aug 1, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Aug 3, 2023
@btlechowski
Copy link

btlechowski commented Sep 7, 2023

Verification PASSED

Brave 1.58.97 Chromium: 116.0.5845.96 (Official Build) beta (64-bit)
Revision c983323d5ff7738a3c8d3bf491a7241c24b4d65a
OS Linux

Verified test plan from brave/brave-core#19522

Run Brave with brave-ads-should-always-run-brave-ads-service

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6,"*/whats_new/*"=9 --variations-server-url=https://variations.bravesoftware.com/seed1 --rewards=staging=true,debug=true --use-dev-goupdater-url --enable-features=ShouldAlwaysRunBraveAdsService,ShouldAlwaysTriggerBraveSearchResultAdEvents,ShouldLaunchBraveAdsAsInProcessService,ShouldSupportSearchResultAds,ShouldAlwaysTriggerBraveNewTabPageAdEvents,CustomNotificationAds

Verified conversion resource is loaded:

[14617:14617:0907/194325.905301:VERBOSE1:conversion_resource.cc(54)] Successfully loaded nnqccijfhvzwyrxpxwjrpmynaiazctqb conversion resource
[14617:14617:0907/194325.906382:VERBOSE1:conversion_resource.cc(62)] Successfully initialized nnqccijfhvzwyrxpxwjrpmynaiazctqb conversion resource version 1


opted-in to rewards
image

Reset rewards
image

Verified conversion resource is loaded:

[14617:14617:0907/194608.866531:VERBOSE1:conversion_resource.cc(54)] Successfully loaded nnqccijfhvzwyrxpxwjrpmynaiazctqb conversion resource
[14617:14617:0907/194608.866842:VERBOSE1:conversion_resource.cc(62)] Successfully initialized nnqccijfhvzwyrxpxwjrpmynaiazctqb conversion resource version 1

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants