Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark and light mode for chromium dialog #16658

Merged
merged 1 commit into from
Jan 18, 2023
Merged

dark and light mode for chromium dialog #16658

merged 1 commit into from
Jan 18, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Jan 13, 2023 •
edited
Loading

Resolves brave/brave-browser#27767

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Dark Mode Light Mode
image image

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 13, 2023
@sujitacharya2005 sujitacharya2005 requested a review from a team as a code owner January 13, 2023 07:33
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: a4d280148983e0cb8ac731a5bd9bc141dbd1ddc7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

1 similar comment
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: a4d280148983e0cb8ac731a5bd9bc141dbd1ddc7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 13, 2023
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: a4d280148983e0cb8ac731a5bd9bc141dbd1ddc7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

1 similar comment
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: a4d280148983e0cb8ac731a5bd9bc141dbd1ddc7
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

@sujitacharya2005 sujitacharya2005 added this to the 1.49.x - Nightly milestone Jan 13, 2023
@sujitacharya2005 sujitacharya2005 force-pushed the 27767_Dark_Light_mode_of_chromium_dialog branch from a4d2801 to bfe00d5 Compare January 13, 2023 07:53
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: bfe00d5ead24dfed381436ed9c92f2fa512b5391
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

deeppandya
deeppandya reviewed Jan 13, 2023
View reviewed changes
android/java/res/drawable/notification_rationale_dialog_background.xml Outdated
<!-- Copyright (c) 2022 The Brave Authors. All rights reserved.
This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this file,
You can obtain one at http://mozilla.org/MPL/2.0/.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: bfe00d5ead24dfed381436ed9c92f2fa512b5391
reason: unsigned
Please follow the handbook to configure commit signing
cc: @sujitacharya2005

@sujitacharya2005 sujitacharya2005 force-pushed the 27767_Dark_Light_mode_of_chromium_dialog branch from bfe00d5 to df5a668 Compare January 13, 2023 08:21
tapanmodh
tapanmodh approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antonok-edm antonok-edm removed the request for review from a team January 13, 2023 20:23
@sujitacharya2005 sujitacharya2005 force-pushed the 27767_Dark_Light_mode_of_chromium_dialog branch from df5a668 to d3591f7 Compare January 16, 2023 06:58
@sujitacharya2005 sujitacharya2005 force-pushed the 27767_Dark_Light_mode_of_chromium_dialog branch from d3591f7 to 0c42d84 Compare January 16, 2023 07:11
deeppandya
deeppandya approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujitacharya2005 sujitacharya2005 merged commit 49e4905 into master Jan 18, 2023
@sujitacharya2005 sujitacharya2005 deleted the 27767_Dark_Light_mode_of_chromium_dialog branch January 18, 2023 12:40
This was referenced Jan 18, 2023
Merged
Merged
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.41 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/TQ1A.230105.002

Light Theme

Example Example Example Example Example Example Example Example
Screenshot_20230118-220158 Screenshot_20230118-220557 Screenshot_20230118-220425 Screenshot_20230118-220608 Screenshot_20230118-220307 Screenshot_20230118-220438 Screenshot_20230118-220325 Screenshot_20230118-223410

Dark Theme

Example Example Example Example Example Example Example Example
Screenshot_20230118-220756 Screenshot_20230118-220841 Screenshot_20230118-220856 Screenshot_20230118-220949 Screenshot_20230118-221057 Screenshot_20230118-221111 Screenshot_20230118-221223 Screenshot_20230118-221235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeppandya deeppandya deeppandya approved these changes

@tapanmodh tapanmodh tapanmodh approved these changes

Assignees

@sujitacharya2005 sujitacharya2005

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging this pull request may close these issues.

Fix notification modal description and textual button color in dark mode - follow up to #27004
4 participants
@sujitacharya2005 @kjozwiak @deeppandya @tapanmodh