Fix notification modal description and textual button color in dark mode - follow up to #27004 #27767
Labels
front-end-change
This task is a front end task and doesn't need any C++ changes
OS/Android
Fixes related to Android browser functionality
QA Pass - Android ARM
QA/Yes
release-notes/include
Milestone
Description
Looking at https://github.com/brave/brave-core/pull/16128/files, it doesn't look like any changes were added into the PR that fixes the colour issue(s) discussed via #27004 (comment). When launching Brave for the first time on
Android 13
, the modal looks the same as before. We need to make sure it we're using the correct colours.Steps to reproduce
Prerequisite: ensure that you're using
dark mode
viaAndroid 13
before launching Brave.Test Case #1
1.49.20 Chromium: 109.0.5414.87
usingAndroid 13
Test Case #2
1.49.20 Chromium: 109.0.5414.87
usingAndroid 13
Settings
->Notifications
and disable all notifications from theNotifications
page<-
(back button) and go back to theSettings
page (notice the general warning is also using the incorrect colours)Actual result
Example
Example
Expected result
Should be using the scheme mentioned via #27004 (comment) and look like https://www.figma.com/file/sdVBBufbl2A11hAgPNfyqG/Android-13-Notifications?node-id=1243%3A31639&t=7Pd5NQyY0I0HjTn0-1. @sujitacharya2005 also added a screenshot of how it was supposed to look via brave/brave-core#16128 (comment).
Issue reproduces how often
100% reproducible using the STR/Cases outlined above.
Version/Channel Information:
Yes
Yes
Yes
Device details
ARM
Pixel 6
(Phone)Android 13
Brave version
Website problems only
N/A
N/A
N/A
Additional information
CCing @deeppandya @timchilds @sujitacharya2005
The text was updated successfully, but these errors were encountered: