-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix brave notification description and textual button color in dark mode #27004
Comments
Thank you @Pavneet-Sing. it seems we are missing dark mode spec here : https://www.figma.com/file/sdVBBufbl2A11hAgPNfyqG/Android-13-Notifications?node-id=366%3A30681&t=kj66ZSk8TrqEpCmt-0 |
@deeppandya @timchilds I've just updated the design for this notification screen. |
we will be updating night mode colors for this issue. |
@deeppandya just in case, here's a quick fix without changing the layout. you could just use updated colors and illustration. https://www.figma.com/file/sdVBBufbl2A11hAgPNfyqG/Android-13-Notifications?node-id=363%3A30672&t=JBalKKlQzJNGa6zV-1 |
The above requires |
Labelling this as |
Description
Notification dialog description color is hard to read in dark mode.
#84889C
color like wallet#A0A5EB
for dark and#4C54D2
for light like walletNote: Make sure to confirm the exact colors with figma if specs are available for dark mode/feature.
Actual result
Expected result
Update colors as per theme/figma.
cc: @sujitacharya2005 @deeppandya
The text was updated successfully, but these errors were encountered: