Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textual button text color for dark theme #25771

Open
Pavneet-Sing opened this issue Oct 3, 2022 · 2 comments
Open

Fix textual button text color for dark theme #25771

Pavneet-Sing opened this issue Oct 3, 2022 · 2 comments
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Oct 3, 2022 •
edited
Loading

Actual result

Screenshot from 2022-10-03 18-48-36

Expected result

The "Restore" button should be blue per brave theme color, #A0A5EB for dark and #4C54D2 for light, use BraveWalletTextButton style

Issue reproduces how often

easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Y
  • Can you reproduce this issue with the current Play Store Beta version? Y
  • Can you reproduce this issue with the current Play Store Nightly version? Y
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Oct 3, 2022
@tcchawla
Copy link

tcchawla commented Oct 4, 2022

Hey @Pavneet-Sing I would like to work on this issue, can you assign this to me?

@Pavneet-Sing
Copy link
Author

Pavneet-Sing commented Nov 28, 2022 •
edited
Loading

@Pavneet-Sing sorry for the late response. You can work on it and raise a PR when it's ready. Happy coding :)

@Pavneet-Sing Pavneet-Sing mentioned this issue Nov 28, 2022
Closed
@HEagle18 HEagle18 moved this to Backlog in Web3 Dec 2, 2022
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include
Projects
Web3
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pavneet-Sing @HEagle18 @tcchawla